From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: David Laight <David.Laight@aculab.com>
Cc: 'Sreenath Vijayan' <sreenath.vijayan@sony.com>,
"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
"corbet@lwn.net" <corbet@lwn.net>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"taichi.shimoyashiki@sony.com" <taichi.shimoyashiki@sony.com>,
"daniel.palmer@sony.com" <daniel.palmer@sony.com>,
"anandakumar.balasubramaniam@sony.com"
<anandakumar.balasubramaniam@sony.com>
Subject: Re: [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq
Date: Fri, 19 Jan 2024 06:47:13 +0100 [thread overview]
Message-ID: <2024011958-coerce-niece-6301@gregkh> (raw)
In-Reply-To: <57f8c1f40ccc4a4f9d29e97f50a36b4f@AcuMS.aculab.com>
On Thu, Jan 18, 2024 at 10:56:59PM +0000, David Laight wrote:
> From: Sreenath Vijayan
> > Sent: 17 January 2024 11:14
> ....
> > /* Key Operations table and lock */
> > static DEFINE_SPINLOCK(sysrq_key_table_lock);
> >
> > @@ -505,7 +523,7 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
> > NULL, /* A */
> > NULL, /* B */
> > NULL, /* C */
> > - NULL, /* D */
> > + &sysrq_dmesg_dump_op, /* D */
> > NULL, /* E */
> > NULL, /* F */
> > NULL, /* G */
>
> That looks like it ought to use C99 initialisers:
> ['D' - 'A'] = &sysrq_dmesg_dump_op,
>
> Possible with a #define to hide the offset.
Maybe in the future, but for now, let's leave it as-is please.
thanks,
greg k-h
prev parent reply other threads:[~2024-01-19 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 10:12 [PATCH v3 0/2] Add support to dump printk buffer to console via sysrq Sreenath Vijayan
2024-01-17 10:12 ` [PATCH v3 1/2] printk: Add function to dump printk buffer directly to consoles Sreenath Vijayan
2024-01-18 9:49 ` John Ogness
2024-01-18 10:14 ` John Ogness
2024-01-20 8:41 ` Sreenath Vijayan
2024-01-17 11:13 ` [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq Sreenath Vijayan
2024-01-17 10:12 ` Sreenath Vijayan
2024-01-18 10:05 ` John Ogness
2024-01-18 22:56 ` David Laight
2024-01-19 5:47 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011958-coerce-niece-6301@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=David.Laight@aculab.com \
--cc=anandakumar.balasubramaniam@sony.com \
--cc=corbet@lwn.net \
--cc=daniel.palmer@sony.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sreenath.vijayan@sony.com \
--cc=taichi.shimoyashiki@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox