public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] perf/bpf: Fix duplicate type check
@ 2024-01-20 15:09 Florian Lehner
  2024-01-26 17:19 ` Daniel Borkmann
  2024-01-29 21:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Florian Lehner @ 2024-01-20 15:09 UTC (permalink / raw)
  To: bpf
  Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung, irogers, adrian.hunter, linux-perf-users, linux-kernel,
	Florian Lehner

Remove the duplicate check on type and unify result.

Signed-off-by: Florian Lehner <dev@der-flo.net>
---
 kernel/events/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index f0f0f71213a1..5ecfa57e3b97 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9302,10 +9302,6 @@ void perf_event_bpf_event(struct bpf_prog *prog,
 {
 	struct perf_bpf_event bpf_event;
 
-	if (type <= PERF_BPF_EVENT_UNKNOWN ||
-	    type >= PERF_BPF_EVENT_MAX)
-		return;
-
 	switch (type) {
 	case PERF_BPF_EVENT_PROG_LOAD:
 	case PERF_BPF_EVENT_PROG_UNLOAD:
@@ -9313,7 +9309,7 @@ void perf_event_bpf_event(struct bpf_prog *prog,
 			perf_event_bpf_emit_ksymbols(prog, type);
 		break;
 	default:
-		break;
+		return;
 	}
 
 	if (!atomic_read(&nr_bpf_events))
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] perf/bpf: Fix duplicate type check
  2024-01-20 15:09 [PATCH bpf-next] perf/bpf: Fix duplicate type check Florian Lehner
@ 2024-01-26 17:19 ` Daniel Borkmann
  2024-01-29 17:19   ` Song Liu
  2024-01-29 21:50 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2024-01-26 17:19 UTC (permalink / raw)
  To: Florian Lehner, bpf
  Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung, irogers, adrian.hunter, linux-perf-users, linux-kernel

On 1/20/24 4:09 PM, Florian Lehner wrote:
> Remove the duplicate check on type and unify result.
> 
> Signed-off-by: Florian Lehner <dev@der-flo.net>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] perf/bpf: Fix duplicate type check
  2024-01-26 17:19 ` Daniel Borkmann
@ 2024-01-29 17:19   ` Song Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Song Liu @ 2024-01-29 17:19 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Florian Lehner, bpf, peterz, mingo, acme, mark.rutland,
	alexander.shishkin, jolsa, namhyung, irogers, adrian.hunter,
	linux-perf-users, linux-kernel

On Fri, Jan 26, 2024 at 9:20 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 1/20/24 4:09 PM, Florian Lehner wrote:
> > Remove the duplicate check on type and unify result.
> >
> > Signed-off-by: Florian Lehner <dev@der-flo.net>
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Acked-by: Song Liu <song@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] perf/bpf: Fix duplicate type check
  2024-01-20 15:09 [PATCH bpf-next] perf/bpf: Fix duplicate type check Florian Lehner
  2024-01-26 17:19 ` Daniel Borkmann
@ 2024-01-29 21:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-29 21:50 UTC (permalink / raw)
  To: Florian Lehner
  Cc: bpf, peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung, irogers, adrian.hunter, linux-perf-users, linux-kernel

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Sat, 20 Jan 2024 16:09:20 +0100 you wrote:
> Remove the duplicate check on type and unify result.
> 
> Signed-off-by: Florian Lehner <dev@der-flo.net>
> ---
>  kernel/events/core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Here is the summary with links:
  - [bpf-next] perf/bpf: Fix duplicate type check
    https://git.kernel.org/bpf/bpf-next/c/aecaa3ed48c3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-29 21:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-20 15:09 [PATCH bpf-next] perf/bpf: Fix duplicate type check Florian Lehner
2024-01-26 17:19 ` Daniel Borkmann
2024-01-29 17:19   ` Song Liu
2024-01-29 21:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox