From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1585102F; Mon, 22 Jan 2024 14:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705935501; cv=none; b=NyS067o3fzL9I+l/GljMyoMb4n0wtWQ0OwCZ9VAzoLjbw2DzvTlVwsG/Ik9tCHH9qZIvT0Xd3Q12f6wXhDmxnhoKcb8GON7FeD8WV0GbAPX9xiDPZnFMe43qrXD5SeLmpSUXQvsup4lAg9SrR8XDXJoI6pdcBscBr8nBUdUm5XU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705935501; c=relaxed/simple; bh=XcqHZjLopTn4lg1x7pKDpFDeFGze++k5rnwJFqSOoF8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ba1+GWoaUCIMd7cjVQO6gQCUKZgBs8M5DfZlGIlkVnkEVSo0G3yYbr73TO1QV/Nx7KyuqBFCik2CfuixnQBhMcBKQx/J3iw8NJIOrS/hnpWqR3zysY8oVPuCNp9a+BQ1bGOdtjcgpp7m0X08LtqVOqHzQg7xxK8YplC2UNKjctg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eACYs+er; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eACYs+er" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE6FBC433B2; Mon, 22 Jan 2024 14:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705935501; bh=XcqHZjLopTn4lg1x7pKDpFDeFGze++k5rnwJFqSOoF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eACYs+erMTG3+V/uBTfkUM4YNpeWCAxnWB8eWV3iIYWxGhyOeIOw/rN+ST9gq/xZG cdnwfrb15fgnxyavtf3f7sI+K5SwnYPyQgw4BjYevHY45rk0oAgxMN4qaG04ruogWL SoyP+bQg5VMGwrgl5K9+DLTjJToqzzxigiUlLWNoH7ld/MsTgaLB6vVyvjrm/ZhTnw xe/1hFc0I2HaaP8QbV5I47s/HhnebfewqSiJe5Fhy1KpVVsYBsPQh6Rbm7wLTbgHRI JDOXFg/Z/fN9mnURWYren4k5o2YMd6aIrsKmXZv0NOTbBCcmG0yZ3OH2vCkwYiACAL qAYcKQuX44p8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomi Valkeinen , Adam Ford , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , dafna@fastmail.com, heiko@sntech.de, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.7 35/88] media: rkisp1: Drop IRQF_SHARED Date: Mon, 22 Jan 2024 09:51:08 -0500 Message-ID: <20240122145608.990137-35-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122145608.990137-1-sashal@kernel.org> References: <20240122145608.990137-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7.1 Content-Transfer-Encoding: 8bit From: Tomi Valkeinen [ Upstream commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74 ] In all known platforms the ISP has dedicated IRQ lines, but for some reason the driver uses IRQF_SHARED. Supporting IRQF_SHARED properly requires handling interrupts even when our device is disabled, and the driver does not handle this. To avoid adding such code, and to be sure the driver won't accidentally be used in a platform with shared interrupts, let's drop the IRQF_SHARED flag. Link: https://lore.kernel.org/r/20231207-rkisp-irq-fix-v3-1-358a2c871a3c@ideasonboard.com Tested-by: Adam Ford #imx8mp-beacon Signed-off-by: Tomi Valkeinen Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index c41abd2833f1..4c4514e20673 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret); -- 2.43.0