From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 745094BA9C; Mon, 22 Jan 2024 15:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936110; cv=none; b=D88oH08U+/BlekmjWEUUI6DmxgF6qbKeo08tTD7Aeu6sjwCB2nekWoTkAm1cYo26kCs3PHSBGtfsF2umkhNxMC9iE3HKTWXnr9QnUKDNzDJ1DPnbZZ/vlnfmFriFZq2qZtJe1N6R0KqXOtA9qilv08RsftATHmZ1fDNeVPvgkhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936110; c=relaxed/simple; bh=vbJzKNdkxlOW9TzMsXP/y6tmSjhna9C18g14aifhggk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lHrbV5May5ZjHf24GGkxbf3ccrF2AIQIWtwtZdsyDyyLJFnP45HuwJ5FtITj+btagELkaNgM1IJFIChOBtg516Q7SOwmvAUNL9/DbGuy5OBkM/N3mHuEHAxviCW2ZFBUQVHSam8rkjDkg2g2F/0uTTcNZlm1Jp657lapaDGwX4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gICm4QHN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gICm4QHN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73DCFC43390; Mon, 22 Jan 2024 15:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936110; bh=vbJzKNdkxlOW9TzMsXP/y6tmSjhna9C18g14aifhggk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gICm4QHNC24BWqoBM47FGrR+7JVcFZp/zp4F1DxF7pv7KSbDMWLvbUUFM3Uhd/S9v aLvhMGoAdzdIDuS1uC5dy9ZO703+Y0GIa0RmBCsUuYGjgaZmSjmP7WC4soRpTBV34U t53WnDdITFI9UQp1rUT0SlYu+WzQpnw650C3MMF7+0rWojwf5htPXh5a4D7twlOwsa E9Furd0vUBZDMaUCBelb3lV6qXQ1yXrSZ6fMpCaXPRV0IlwfxxSqVPokEeY8Iqa4NU 2/v4k6yeJ2lrMmLHoGd8XVgG8KjoByPmI8B2Gr8wzZy037uOzzf1UOuJqPiCalBMHl Ht5u2hwQlsjdA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Felix Kuehling , Sasha Levin , Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 67/73] drm/amdkfd: Fix iterator used outside loop in 'kfd_add_peer_prop()' Date: Mon, 22 Jan 2024 10:02:21 -0500 Message-ID: <20240122150432.992458-67-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150432.992458-1-sashal@kernel.org> References: <20240122150432.992458-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.13 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit b1a428b45dc7e47c7acc2ad0d08d8a6dda910c4c ] Fix the following about iterator use: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1456 kfd_add_peer_prop() warn: iterator used outside loop: 'iolink3' Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 24 ++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index c8c75ff7cea8..b9988b4fe2f5 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c @@ -1449,17 +1449,19 @@ static int kfd_add_peer_prop(struct kfd_topology_device *kdev, /* CPU->CPU link*/ cpu_dev = kfd_topology_device_by_proximity_domain(iolink1->node_to); if (cpu_dev) { - list_for_each_entry(iolink3, &cpu_dev->io_link_props, list) - if (iolink3->node_to == iolink2->node_to) - break; - - props->weight += iolink3->weight; - props->min_latency += iolink3->min_latency; - props->max_latency += iolink3->max_latency; - props->min_bandwidth = min(props->min_bandwidth, - iolink3->min_bandwidth); - props->max_bandwidth = min(props->max_bandwidth, - iolink3->max_bandwidth); + list_for_each_entry(iolink3, &cpu_dev->io_link_props, list) { + if (iolink3->node_to != iolink2->node_to) + continue; + + props->weight += iolink3->weight; + props->min_latency += iolink3->min_latency; + props->max_latency += iolink3->max_latency; + props->min_bandwidth = min(props->min_bandwidth, + iolink3->min_bandwidth); + props->max_bandwidth = min(props->max_bandwidth, + iolink3->max_bandwidth); + break; + } } else { WARN(1, "CPU node not found"); } -- 2.43.0