From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D49C82D7B; Mon, 22 Jan 2024 15:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936251; cv=none; b=RDNHsvimb8szBk60qZ7B1FgKFbhWmwu7vwggrCEVk8Zx4ifhrALzcLxx82ARnTU2j3TaX6YonyBBEU/vA4RYbGusyFlygQvtWA3aFcbfWq4gNTygwEr50cmeP+usEVxb5hYoHslcRAxhAMTRYNeXpTsJW8zK2/IvekDxmnfF04M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936251; c=relaxed/simple; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=diqhlrUIB2nPs3hYz/VXKV9YD3Fj3ZdLcj76Xa/kxEbkITQWirSqMa6Cvbc1PEAdqPFnvrjIQ/qG7DJWpEqYsiunn+7QtR+foLdRgDFzIJ30pRN5y4xYIAXylft4wgO4A0UjA9qkCic3++zD+yB9ikycdhN/AF3rnV6Oiln/5Ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qpdyXTZ6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qpdyXTZ6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD6EC433F1; Mon, 22 Jan 2024 15:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936251; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qpdyXTZ6Ebdc7lFfLyt/UDMx0O5Wb202loKRM5DcfzV0mWImWBKwtBUEyPVlTNDHu lV67Jg/ad51Ds9RhbxgyCm1ntguzY8yLoL6gaDcTn97qETHtTK0/yOoYwQB9DQuP4r LjZBTthrHLtW9t30FKveklT9SGPIAc1o/FenF0gscErLChCbYDvXyVT/xhDa+LzeYU ULiurS8efeaMCONltMcjZVUGx3MLhf4CUasEpZV6RdgGoXq6EB+Bvvfo/URsj990VL dfK8FHY4igs/WDjZC+1JesTczWblRWYlG/bIJdIoq+gWc6U26/DfN83ozMQ3i+lF7Y HV1AW5QX6uRow== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomi Valkeinen , Adam Ford , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , dafna@fastmail.com, heiko@sntech.de, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 23/53] media: rkisp1: Drop IRQF_SHARED Date: Mon, 22 Jan 2024 10:08:24 -0500 Message-ID: <20240122150949.994249-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 Content-Transfer-Encoding: 8bit From: Tomi Valkeinen [ Upstream commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74 ] In all known platforms the ISP has dedicated IRQ lines, but for some reason the driver uses IRQF_SHARED. Supporting IRQF_SHARED properly requires handling interrupts even when our device is disabled, and the driver does not handle this. To avoid adding such code, and to be sure the driver won't accidentally be used in a platform with shared interrupts, let's drop the IRQF_SHARED flag. Link: https://lore.kernel.org/r/20231207-rkisp-irq-fix-v3-1-358a2c871a3c@ideasonboard.com Tested-by: Adam Ford #imx8mp-beacon Signed-off-by: Tomi Valkeinen Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index f2475c6235ea..e2352a056098 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret); -- 2.43.0