From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25D9312BF11; Mon, 22 Jan 2024 15:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936342; cv=none; b=E8/9gbVs6x1CGfJ0p3BUxNfa/msmy77OvOH9Pv6vSqDyVrfu/p9dgy2tN8aOpXjP38LRQIJrqXAKFXfqph+138Rtx2gIV4ZPkF46i1EKZoMKaoUHVBxOSw4MqsvhSQtHvS6JEHVhlj/UYyjdeb6/ChTP74pxOGPPb5UcMFzIyfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936342; c=relaxed/simple; bh=g+NLjclfFpmz90ce/DyP/hk3mJkJ7WyLtF/ExALF3/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IRKqZwENmJPd2gu/vDkwHrfks2nDWhu191ehyrjefAqTDstANXsGSGkfui31UyCOIzHYmzqgOcBP+ll95XHyTidFKqkLqu9t9MbSg8VuiSwigxTDtg5e5z03fyeCya5mJWUNwamDKlPfPf6GIKZ2Yb+45jSFr8hh/1c6ICD5Htg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vK35pwXL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vK35pwXL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 869EFC43394; Mon, 22 Jan 2024 15:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936342; bh=g+NLjclfFpmz90ce/DyP/hk3mJkJ7WyLtF/ExALF3/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vK35pwXLrrRZoBAsPR+udTDOpD8G25e53qzPrOfPZw3WwDE+E2orNgdHTF/RmkDRB WbRPvd70vv/ilO3xxdt5icxpBrOsmBn53HIHovBmSJAmJTNxogT6TP7w+HLK9bP25z lwvyn2zwCiJmdQKJzQXq+/hp5VZhFuuTQM8AtV1RdcA+Sp2EK3sCB4uGAJPbXeg2uQ SR/xCsA+fNQ200zLdvFJslJDoDkGoQUz2krcc5Ahsp/nwEKlPcCR953nrW7QP9nKZf R1HCvm4VG9VJMixrpiiIZ8f3df4eKSFMiwoD21XIaKzntUCtBQWB/urIOOGoiT3DZk JVlEGk9IynYtw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Felix Kuehling , Sasha Levin , Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.1 48/53] drm/amdgpu: Drop 'fence' check in 'to_amdgpu_amdkfd_fence()' Date: Mon, 22 Jan 2024 10:08:49 -0500 Message-ID: <20240122150949.994249-48-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit bf2ad4fb8adca89374b54b225d494e0b1956dbea ] Return value of container_of(...) can't be null, so null check is not required for 'fence'. Hence drop its NULL check. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c:93 to_amdgpu_amdkfd_fence() warn: can 'fence' even be NULL? Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c index 469785d33791..1ef758ac5076 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c @@ -90,7 +90,7 @@ struct amdgpu_amdkfd_fence *to_amdgpu_amdkfd_fence(struct dma_fence *f) return NULL; fence = container_of(f, struct amdgpu_amdkfd_fence, base); - if (fence && f->ops == &amdkfd_fence_ops) + if (f->ops == &amdkfd_fence_ops) return fence; return NULL; -- 2.43.0