From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Ghanshyam Agrawal <ghanshyam1898@gmail.com>,
Phillip Potter <phil@philpotter.co.uk>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sasha Levin <sashal@kernel.org>,
ezequiel@vanguardiasur.com.ar, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 10/24] media: stk1160: Fixed high volume of stk1160_dbg messages
Date: Mon, 22 Jan 2024 10:16:24 -0500 [thread overview]
Message-ID: <20240122151659.997085-10-sashal@kernel.org> (raw)
In-Reply-To: <20240122151659.997085-1-sashal@kernel.org>
From: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
[ Upstream commit b3695e86d25aafbe175dd51f6aaf6f68d341d590 ]
The function stk1160_dbg gets called too many times, which causes
the output to get flooded with messages. Since stk1160_dbg uses
printk, it is now replaced with printk_ratelimited.
Suggested-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/media/usb/stk1160/stk1160-video.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
index 202b084f65a2..4cf540d1b250 100644
--- a/drivers/media/usb/stk1160/stk1160-video.c
+++ b/drivers/media/usb/stk1160/stk1160-video.c
@@ -107,8 +107,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/*
* TODO: These stk1160_dbg are very spammy!
- * We should 1) check why we are getting them
- * and 2) add ratelimit.
+ * We should check why we are getting them.
*
* UPDATE: One of the reasons (the only one?) for getting these
* is incorrect standard (mismatch between expected and configured).
@@ -151,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/* Let the bug hunt begin! sanity checks! */
if (lencopy < 0) {
- stk1160_dbg("copy skipped: negative lencopy\n");
+ printk_ratelimited(KERN_DEBUG "copy skipped: negative lencopy\n");
return;
}
--
2.43.0
next prev parent reply other threads:[~2024-01-22 15:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:16 [PATCH AUTOSEL 5.4 01/24] f2fs: fix to check return value of f2fs_reserve_new_block() Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 02/24] ALSA: hda: Refer to correct stream index at loops Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 03/24] ASoC: doc: Fix undefined SND_SOC_DAPM_NOPM argument Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 04/24] fast_dput(): handle underflows gracefully Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 05/24] RDMA/IPoIB: Fix error code return in ipoib_mcast_join Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 06/24] drm/amd/display: Fix writeback_info never got updated Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 07/24] drm/drm_file: fix use of uninitialized variable Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 08/24] drm/framebuffer: Fix " Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 09/24] drm/mipi-dsi: Fix detach call without attach Sasha Levin
2024-01-22 15:16 ` Sasha Levin [this message]
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 11/24] media: rockchip: rga: fix swizzling for RGB formats Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 12/24] PCI: add INTEL_HDA_ARL to pci_ids.h Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 13/24] ALSA: hda: Intel: add HDA_ARL PCI ID support Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 14/24] hwmon: (pc87360) Bounds check data->innr usage Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 15/24] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 16/24] IB/ipoib: Fix mcast list locking Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 17/24] media: ddbridge: fix an error code problem in ddb_probe Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 18/24] drm/msm/dpu: Ratelimit framedone timeout msgs Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 19/24] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init() Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 20/24] clk: mmp: pxa168: Fix memory leak in pxa168_clk_init() Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 21/24] watchdog: it87_wdt: Keep WDTCTRL bit 3 unmodified for IT8784/IT8786 Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 22/24] drm/amd/display: make flip_timestamp_in_us a 64-bit variable Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 23/24] drm/amdgpu: Let KFD sync with VM fences Sasha Levin
2024-01-22 15:16 ` [PATCH AUTOSEL 5.4 24/24] drm/amdgpu: Drop 'fence' check in 'to_amdgpu_amdkfd_fence()' Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122151659.997085-10-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=ghanshyam1898@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phil@philpotter.co.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox