From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE55C154C01; Mon, 22 Jan 2024 15:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936767; cv=none; b=L3GgV3tEUlBv2MDM9XfzJaf5vYSYKqxWM1v5dY0cNdqvq6FNK7QgLCFqOUIsB/pw6az2VxCoHqj7qUzEnki20Mn2+lv1jVfLcpSEvgB6/ClBDHRxavzdm2k8BoXJtu8Z23UHR9pBBQ8JYWac4Xn3BxDfc7q3S5LzOcSFOhAQHzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936767; c=relaxed/simple; bh=VJgGLZRJj1/aRH1kDurCsLU64GVGU7ctEoU9UEy2bcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YgKQut2NDJH/Tlse47UPIf1GiywUYSzxN0QTJZ0tIRghx2Wyk9tuRv0rHii6gje0CIhJmRjxkzKg2aLNehiJV5axv/DDaXGAsO+iITNSG6Z7sBL+ta1446EdTMcVzlQ/woKM3tI1NxPaWvntdasZD9ZNeX/Gl+q7D3aDsr0s9FQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XQutGVTB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XQutGVTB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AD9DC433C7; Mon, 22 Jan 2024 15:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936767; bh=VJgGLZRJj1/aRH1kDurCsLU64GVGU7ctEoU9UEy2bcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XQutGVTBjWbHogczdreGzFmydJVKfs/n1PrN/2Gp6h3M86dwnNOLC1EaJIYjoAwWg g+QHbBuUYi/1kfCnGEcRLY/Odl061oBR4bDyMhZS36nU8kZVtEtcoVH63liOYmAO7i 61jlhUyFiS3gC8/KbIAvPOuggd5K+aqN+IlLw9c1TaFSHaLtgodlUtMmyUdm6q6BVz blcHy1LUmwKAmv4AC8xxAxtNE6iyW/SK5iev0CIQRgv0hdClorIVUPkxFV3NhEHtp6 mmfkZGNO3dpfD/zDBsZOjPR9jSxdFIZmscGca8bR6XvJJOzIbYpgJgOpMCOMSL9nKO 1EE4wsqqi+c6A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Felix Kuehling , Sasha Levin , Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.19 23/23] drm/amdgpu: Drop 'fence' check in 'to_amdgpu_amdkfd_fence()' Date: Mon, 22 Jan 2024 10:18:03 -0500 Message-ID: <20240122151823.997644-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122151823.997644-1-sashal@kernel.org> References: <20240122151823.997644-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.305 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit bf2ad4fb8adca89374b54b225d494e0b1956dbea ] Return value of container_of(...) can't be null, so null check is not required for 'fence'. Hence drop its NULL check. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c:93 to_amdgpu_amdkfd_fence() warn: can 'fence' even be NULL? Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c index 574c1181ae9a..75e4f1abb4c9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c @@ -88,7 +88,7 @@ struct amdgpu_amdkfd_fence *to_amdgpu_amdkfd_fence(struct dma_fence *f) return NULL; fence = container_of(f, struct amdgpu_amdkfd_fence, base); - if (fence && f->ops == &amdkfd_fence_ops) + if (f->ops == &amdkfd_fence_ops) return fence; return NULL; -- 2.43.0