From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F3A652F82; Mon, 22 Jan 2024 18:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705948503; cv=none; b=lsqZ15AMHQ0YdxDkunKxCXelAJPH8aAgCG4YHno4DA71bCFNGw+tbgOT0XkYCPBzlCls7aDxHSBLvx9ItzqeuYO/uzXBaFXC85owZwk4LZWu8Lx/ABhk125TS9sBXbH/CXLEbwzT0aX/IGwHq9jk8xhaDAOl1x0NCciOjZxY+qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705948503; c=relaxed/simple; bh=NaSm4PL9mjXmeJVxnRLI3oLtxgzdUSU3gKxUHBwsTbw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a6Xf12BzFc5OlC+U+YtrRAVVg9DwnR5z2ssD5Bf+iXq1H3XsW+i4I7yUgLedKEzVyU6bFYIgmX3kSUCD6Cc4PCOYsTLV9eN6BA9KuT3PTqS7pqzYMCOFWs4eZ8cQ+mhO5F4evjZCHyI3DuoT+xGbil63dC9NrTb7qXfZLW8Qe94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Gama1S3a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Gama1S3a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7018C433F1; Mon, 22 Jan 2024 18:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705948503; bh=NaSm4PL9mjXmeJVxnRLI3oLtxgzdUSU3gKxUHBwsTbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gama1S3aFPrTk0Mx+DoGLjb84uPr48ithjLZxXboGqcI4I1gmImsnbaz3vpPgEM0N eFgqKFB+9rekP/NVJdWZGvY2ABUP/o+pQuOTDqLcRtceXYtBMqceGLNo2qKCuN8HcB VeMazrpIPgXqBqFkwXD/5fG1toH87LCOHOhSSQ5A= Date: Mon, 22 Jan 2024 10:35:01 -0800 From: Greg Kroah-Hartman To: Carlos Llamas Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Sherry Yang , linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH v2 05/28] binder: fix unused alloc->free_async_space Message-ID: <2024012254-encore-pedometer-42e9@gregkh> References: <20231201172212.1813387-1-cmllamas@google.com> <20231201172212.1813387-6-cmllamas@google.com> <2024011955-quotation-zone-7f20@gregkh> <2024012203-expedited-job-1d79@gregkh> <2024012214-ideology-curvature-febb@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 22, 2024 at 06:08:36PM +0000, Carlos Llamas wrote: > On Mon, Jan 22, 2024 at 07:05:29AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Jan 22, 2024 at 07:04:20AM -0800, Greg Kroah-Hartman wrote: > > > On Fri, Jan 19, 2024 at 05:27:18PM +0000, Carlos Llamas wrote: > > > > On Fri, Jan 19, 2024 at 06:49:00AM +0100, Greg Kroah-Hartman wrote: > > > > > On Thu, Jan 18, 2024 at 07:33:48PM +0000, Carlos Llamas wrote: > > > > > > On Fri, Dec 01, 2023 at 05:21:34PM +0000, Carlos Llamas wrote: > > > > > > > Each transaction is associated with a 'struct binder_buffer' that stores > > > > > > > the metadata about its buffer area. Since commit 74310e06be4d ("android: > > > > > > > binder: Move buffer out of area shared with user space") this struct is > > > > > > > no longer embedded within the buffer itself but is instead allocated on > > > > > > > the heap to prevent userspace access to this driver-exclusive info. > > > > > > > > > > > > > > Unfortunately, the space of this struct is still being accounted for in > > > > > > > the total buffer size calculation, specifically for async transactions. > > > > > > > This results in an additional 104 bytes added to every async buffer > > > > > > > request, and this area is never used. > > > > > > > > > > > > > > This wasted space can be substantial. If we consider the maximum mmap > > > > > > > buffer space of SZ_4M, the driver will reserve half of it for async > > > > > > > transactions, or 0x200000. This area should, in theory, accommodate up > > > > > > > to 262,144 buffers of the minimum 8-byte size. However, after adding > > > > > > > the extra 'sizeof(struct binder_buffer)', the total number of buffers > > > > > > > drops to only 18,724, which is a sad 7.14% of the actual capacity. > > > > > > > > > > > > > > This patch fixes the buffer size calculation to enable the utilization > > > > > > > of the entire async buffer space. This is expected to reduce the number > > > > > > > of -ENOSPC errors that are seen on the field. > > > > > > > > > > > > > > Fixes: 74310e06be4d ("android: binder: Move buffer out of area shared with user space") > > > > > > > Signed-off-by: Carlos Llamas > > > > > > > --- > > > > > > > > > > > > Sorry, I forgot to Cc: stable@vger.kernel.org. > > > > > > > > > > > > > > > > > > > > > > > > > This is not the correct way to submit patches for inclusion in the > > > > > stable kernel tree. Please read: > > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > for how to do this properly. > > > > > > > > > > > > > > > > > > Oops, here is the complete info: > > > > > > > > Commit ID: c6d05e0762ab276102246d24affd1e116a46aa0c > > > > Subject: "binder: fix unused alloc->free_async_space" > > > > Reason: Fixes an incorrect calculation of available space. > > > > Versions: v4.19+ > > > > > > > > Note this patch will also have trivial conflicts in v4.19 and v5.4 > > > > kernels as commit 261e7818f06e is missing there. Please let me know and > > > > I can send the corresponding patches separately. > > > > > > It doesn't even apply to 6.7.y either, so we need backports for all > > > affected trees, thanks. > > > > Now I got it to apply, but we need backports for 5.4.y and 4.19.y, > > thanks. > > > > greg k-h > > Backports sent. > > linux-4.19.y: > https://lore.kernel.org/all/20240122174250.2123854-2-cmllamas@google.com/ > > linux-5.4.y: > https://lore.kernel.org/all/20240122175751.2214176-2-cmllamas@google.com/ All now queued up, thanks! greg k-h