From: Ye Bin <yebin10@huawei.com>
To: <rostedt@goodmis.org>, <mhiramat@kernel.org>,
<mathieu.desnoyers@efficios.com>,
<linux-trace-kernel@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <yebin10@huawei.com>
Subject: [PATCH v4 4/7] tracing/probes: support '%pD' type for print struct file's name
Date: Tue, 23 Jan 2024 17:21:36 +0800 [thread overview]
Message-ID: <20240123092139.3698375-5-yebin10@huawei.com> (raw)
In-Reply-To: <20240123092139.3698375-1-yebin10@huawei.com>
Similar to '%pD' for printk, use '%pD' for print struct file's name.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
kernel/trace/trace_probe.c | 41 ++++++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index cc8bd7ea5341..a664633137a0 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -12,6 +12,7 @@
#define pr_fmt(fmt) "trace_probe: " fmt
#include <linux/bpf.h>
+#include <linux/fs.h>
#include "trace_btf.h"
#include "trace_probe.h"
@@ -1574,28 +1575,38 @@ int traceprobe_expand_dentry_args(int argc, const char *argv[], char *buf,
for (i = 0; i < argc; i++) {
size_t idx;
- if (str_has_suffix(argv[i], ":%pd", &idx)) {
- char *tmp = kstrdup(argv[i], GFP_KERNEL);
- char *equal;
+ if (!str_has_suffix(argv[i], ":%pd", &idx) &&
+ !str_has_suffix(argv[i], ":%pD", &idx))
+ continue;
- if (!tmp)
- return -ENOMEM;
+ char *tmp = kstrdup(argv[i], GFP_KERNEL);
+ char *equal;
+
+ if (!tmp)
+ return -ENOMEM;
- equal = strchr(tmp, '=');
- if (equal)
- *equal = '\0';
- tmp[idx] = '\0';
+ equal = strchr(tmp, '=');
+ if (equal)
+ *equal = '\0';
+ tmp[idx] = '\0';
+ if (argv[i][idx + 3] == 'd')
ret = snprintf(buf + used, bufsize - used,
"%s%s+0x0(+0x%zx(%s)):string",
equal ? tmp : "", equal ? "=" : "",
offsetof(struct dentry, d_name.name),
equal ? equal + 1 : tmp);
- kfree(tmp);
- if (ret >= bufsize - used)
- return -ENOMEM;
- argv[i] = buf + used;
- used += ret + 1;
- }
+ else
+ ret = snprintf(buf + used, bufsize - used,
+ "%s%s+0x0(+0x%zx(+0x%zx(%s))):string",
+ equal ? tmp : "", equal ? "=" : "",
+ offsetof(struct dentry, d_name.name),
+ offsetof(struct file, f_path.dentry),
+ equal ? equal + 1 : tmp);
+ kfree(tmp);
+ if (ret >= bufsize - used)
+ return -ENOMEM;
+ argv[i] = buf + used;
+ used += ret + 1;
}
return 0;
--
2.31.1
next prev parent reply other threads:[~2024-01-23 9:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 9:21 [PATCH v4 0/7] support '%pd' and '%pD' for print file name Ye Bin
2024-01-23 9:21 ` [PATCH v4 1/7] string.h: add str_has_suffix() helper for test string ends with specify string Ye Bin
2024-01-23 9:21 ` [PATCH v4 2/7] tracing/probes: add traceprobe_expand_dentry_args() helper Ye Bin
2024-01-23 14:26 ` Masami Hiramatsu
2024-01-23 9:21 ` [PATCH v4 3/7] tracing/probes: support '%pd' type for print struct dentry's name Ye Bin
2024-01-23 14:40 ` Masami Hiramatsu
2024-01-24 2:46 ` yebin (H)
2024-01-24 12:27 ` Masami Hiramatsu
2024-01-23 9:21 ` Ye Bin [this message]
2024-01-23 9:21 ` [PATCH v4 5/7] tracing: add new type "%pd/%pD" in readme_msg[] Ye Bin
2024-01-23 9:21 ` [PATCH v4 6/7] Documentation: tracing: add new type '%pd' and '%pD' for kprobe Ye Bin
2024-01-23 13:07 ` Masami Hiramatsu
2024-01-23 9:21 ` [PATCH v4 7/7] selftests/ftrace: add test cases for VFS type "%pd" and "%pD" Ye Bin
2024-01-24 1:32 ` Masami Hiramatsu
2024-01-24 1:53 ` yebin (H)
2024-01-24 3:21 ` yebin (H)
2024-01-24 23:30 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123092139.3698375-5-yebin10@huawei.com \
--to=yebin10@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox