From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
regressions@lists.linux.dev, "Rafał Miłecki" <rafal@milecki.pl>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
asahi@lists.linux.dev, "Sven Peter" <sven@svenpeter.dev>,
"Michael Walle" <michael@walle.cc>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: include bit index in cell sysfs file name
Date: Wed, 24 Jan 2024 23:11:20 +0100 [thread overview]
Message-ID: <20240124231120.562f06f3@xps-13> (raw)
In-Reply-To: <1d13250c-e48b-4e31-b449-5b54837a0d40@app.fastmail.com>
Hi Arnd,
arnd@arndb.de wrote on Wed, 24 Jan 2024 20:49:53 +0100:
> On Wed, Jan 24, 2024, at 18:22, Miquel Raynal wrote:
> > arnd@kernel.org wrote on Mon, 22 Jan 2024 16:34:10 +0100:
> >
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >>
> >> As far as I can tell, this is a problem for any device with multiple cells on
> >> different bits of the same address. Avoid the issue by changing the file name
> >> to include the first bit number.
> >
> > There is only one bit number right? We are talking about byte offsets
> > so this value can only range from 0 to 7? If we understand each other
> > correctly then why not, I'm fine with the extra ",0" thing.
>
> On the Apple M1, the nvmem registers are 32 bit wide, so the
> bit numbers can go up to 31. I can imagine some system using
> 64-bit registers, but it's unlikely to be higher than that.
In this case we will soon or later have a problem again. Can we include
the full offset of the bit and not just the first digit?
Thanks,
Miquèl
next prev parent reply other threads:[~2024-01-24 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:34 [PATCH] nvmem: include bit index in cell sysfs file name Arnd Bergmann
2024-01-22 16:55 ` Srinivas Kandagatla
2024-02-09 9:09 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-09 10:20 ` Arnd Bergmann
2024-01-24 17:22 ` Miquel Raynal
2024-01-24 19:49 ` Arnd Bergmann
2024-01-24 22:11 ` Miquel Raynal [this message]
2024-01-25 12:15 ` Arnd Bergmann
2024-01-25 13:06 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2024-02-09 16:34 srinivas.kandagatla
2024-02-09 16:49 ` Eric Curtin
2024-02-13 19:20 ` Miquel Raynal
2024-02-14 15:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124231120.562f06f3@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=rafal@milecki.pl \
--cc=regressions@lists.linux.dev \
--cc=srinivas.kandagatla@linaro.org \
--cc=sven@svenpeter.dev \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox