From: Brett Creeley <brett.creeley@amd.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <shannon.nelson@amd.com>, <brett.creeley@amd.com>
Subject: [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ race condition cleanup
Date: Fri, 26 Jan 2024 09:42:45 -0800 [thread overview]
Message-ID: <20240126174255.17052-1-brett.creeley@amd.com> (raw)
This series includes the following changes:
There can be many users of the pds_core's adminq. This includes
pds_core's uses and any clients that depend on it. When the pds_core
device goes through a reset for any reason the adminq is freed
and reconfigured. There are some gaps in the current implementation
that will cause crashes during reset if any of the previously mentioned
users of the adminq attempt to use it after it's been freed.
Issues around how resets are handled, specifically regarding the driver's
error handlers.
Some general cleanups.
v1:
https://lore.kernel.org/netdev/20240104171221.31399-1-brett.creeley@amd.com/
v2:
- Combined the RCT clean-ups with an incorrect goto label fix
- Added a couple more patches related to reset flows
- Slightly updated the cover letter to mention the extra patches that
were added
- Changed a function used only once to be static
Brett Creeley (10):
pds_core: Prevent health thread from running during reset/remove
pds_core: Cancel AQ work on teardown
pds_core: Use struct pdsc for the pdsc_adminq_isr private data
pds_core: Prevent race issues involving the adminq
pds_core: Clear BARs on reset
pds_core: Don't assign interrupt index/bound_intr to notifyq
pds_core: Unmask adminq interrupt in work thread
pds_core: Fix up some minor issues
pds_core: Rework teardown/setup flow to be more common
pds_core: Clean up init/uninit flows to be more readable
drivers/net/ethernet/amd/pds_core/adminq.c | 74 +++++++----
drivers/net/ethernet/amd/pds_core/core.c | 130 ++++++++++++--------
drivers/net/ethernet/amd/pds_core/core.h | 3 +-
drivers/net/ethernet/amd/pds_core/debugfs.c | 12 +-
drivers/net/ethernet/amd/pds_core/dev.c | 30 +++--
drivers/net/ethernet/amd/pds_core/devlink.c | 3 +-
drivers/net/ethernet/amd/pds_core/fw.c | 3 +
drivers/net/ethernet/amd/pds_core/main.c | 26 +++-
8 files changed, 187 insertions(+), 94 deletions(-)
--
2.17.1
next reply other threads:[~2024-01-26 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:42 Brett Creeley [this message]
2024-01-26 17:42 ` [PATCH v2 net-next 01/10] pds_core: Prevent health thread from running during reset/remove Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 02/10] pds_core: Cancel AQ work on teardown Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 03/10] pds_core: Use struct pdsc for the pdsc_adminq_isr private data Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 04/10] pds_core: Prevent race issues involving the adminq Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 05/10] pds_core: Clear BARs on reset Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 06/10] pds_core: Don't assign interrupt index/bound_intr to notifyq Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 07/10] pds_core: Unmask adminq interrupt in work thread Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 08/10] pds_core: Fix up some minor issues Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 09/10] pds_core: Rework teardown/setup flow to be more common Brett Creeley
2024-01-26 17:42 ` [PATCH v2 net-next 10/10] pds_core: Clean up init/uninit flows to be more readable Brett Creeley
2024-01-27 4:44 ` [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ race condition cleanup Jakub Kicinski
2024-01-29 17:27 ` Brett Creeley
2024-01-29 20:05 ` Jakub Kicinski
2024-01-29 21:12 ` Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126174255.17052-1-brett.creeley@amd.com \
--to=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox