Re: [PATCH] eventfs: Have inodes have unique inode numbers

Mathieu Desnoyers
2024-01-29T16:00:10Z

On 2024-01-26 17:49, Linus Torvalds wrote:
> On Fri, 26 Jan 2024 at 14:41, Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>>
>> Yes, there is even a note about stat.st_size in inode(7) explaining
>> this:
>
> Good. Send a patch to do the same for st_ino.

This breaks "cp -aH" and "cp -aL". Even setting st_nlink={0,1}
does not help there, from coreutils 9.1:

copy_internal():

[...]
else if (x->preserve_links
&& !x->hard_link
&& (1 < src_sb.st_nlink
|| (command_line_arg
&& x->dereference == DEREF_COMMAND_LINE_ARGUMENTS)
|| x->dereference == DEREF_ALWAYS))
{
earlier_file = remember_copied (dst_relname,
src_sb.st_ino, src_sb.st_dev);
}

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.