From: Al Viro <viro@zeniv.linux.org.uk>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [overlayfs?] possible deadlock in seq_read_iter (2)
Date: Sun, 28 Jan 2024 21:43:35 +0000 [thread overview]
Message-ID: <20240128214335.GE2087318@ZenIV> (raw)
In-Reply-To: <20240127114610.961-1-hdanton@sina.com>
On Sat, Jan 27, 2024 at 07:46:10PM +0800, Hillf Danton wrote:
> On Tue, 19 Dec 2023 11:43:27 -0800
> > syzbot has found a reproducer for the following issue on:
> >
> > HEAD commit: 2cf4f94d8e86 Merge tag 'scsi-fixes' of git://git.kernel.or..
> > git tree: upstream
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=154aa8d6e80000
>
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2cf4f94d8e86
>
> --- x/fs/namei.c
> +++ y/fs/namei.c
> @@ -3533,6 +3533,8 @@ static const char *open_last_lookups(str
>
> if (open_flag & (O_CREAT | O_TRUNC | O_WRONLY | O_RDWR)) {
> got_write = !mnt_want_write(nd->path.mnt);
> + if (!got_write && (open_flag & O_CREAT))
> + return ERR_PTR(-EISDIR);
NAK.
Please, RTFComment just below your addition. Besides, EISDIR is
obviously bogus in a lot of cases, starting with attempting to
create a new file on a read-only filesystem. Surely
echo bugger > /mnt/cdrom/no_such_file_there
should *not* fail with "no_such_file_there: Is a directory"?
next prev parent reply other threads:[~2024-01-28 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 13:17 [syzbot] [overlayfs?] possible deadlock in seq_read_iter (2) syzbot
2023-12-19 19:43 ` syzbot
2024-01-27 11:46 ` Hillf Danton
2024-01-27 11:57 ` syzbot
2024-01-28 21:43 ` Al Viro [this message]
2024-01-29 5:07 ` Hillf Danton
2024-01-28 7:53 ` Hillf Danton
2024-01-28 8:24 ` syzbot
2023-12-20 0:30 ` syzbot
2023-12-20 3:53 ` Amir Goldstein
2023-12-20 4:13 ` syzbot
2024-01-27 2:28 ` syzbot
2024-01-28 10:11 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240128214335.GE2087318@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox