Re: [PATCH v2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter

Rob Herring
2024-01-31T19:04:23Z

On Mon, Jan 29, 2024 at 04:31:15PM +0800, Charles Hsu wrote:
> Add support for mpq8785 device from Monolithic Power Systems, Inc.
> (MPS) vendor. This is synchronous step-down controller.
>
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>
> ---
> Change in v1:
> Initial patchset.
> Change in v2:
> 1.Add pmbus support status registers.
> 2.Add mpq8785 in trivial-devices.yaml.
> 3.Remove format[PSC_VOLTAGE_OUT]
> 4.Fix MODULE_DESCRIPTION
> ---
> .../devicetree/bindings/trivial-devices.yaml | 2 +

Bindings are a separate patch. checkpatch.pl will tell you this.

> Documentation/hwmon/index.rst | 1 +
> Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++
> drivers/hwmon/pmbus/Kconfig | 9 ++
> drivers/hwmon/pmbus/Makefile | 1 +
> drivers/hwmon/pmbus/mpq8785.c | 62 ++++++++++++
> 6 files changed, 169 insertions(+)
> create mode 100644 Documentation/hwmon/mpq8785.rst
> create mode 100644 drivers/hwmon/pmbus/mpq8785.c