From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34F2163A8C; Mon, 29 Jan 2024 18:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706553399; cv=none; b=QtdNcVAn3EQuwSd00vbjzVEYR2cS1fDzpc6MVXckTzUnmsLURHHSlZiPqBE03NXhpkIxW/VUjA+jO32CoZVC413wdq1mLIG/Y34I9No0claLoTcTeC1OXK+YCfTFx2zlAOsc0UWOdkNPYERRe+LehYk2beZC6oLTgrYFBtGQrEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706553399; c=relaxed/simple; bh=IJj+o+sqNxtyfAHUVNauVEUUerzlkQDRMA0j72uWKmI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N9lJDgtB5JplnRIY0hoHUkD3+pA9QteJ/R/umizaIfLPRmpwW+f5/VCYEhe08R4TygXP547T8/S7vhLIC0vREl2hejhSbA2+PsT+4rb/uZkAhma6hi5XZBk7AnN6ldI6qWwp9jCA1UyvM3uxFNcgDBEPk/wZ8ayuclGAFFiNiyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vPN5xLNO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vPN5xLNO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74C27C43390; Mon, 29 Jan 2024 18:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706553399; bh=IJj+o+sqNxtyfAHUVNauVEUUerzlkQDRMA0j72uWKmI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vPN5xLNOpOpRlkUog7YHfMKMO6iZF+vOs831QFi6dVHLUFEXwWXBwlty5hJDCq02s T2HlFCogdYR6VkZqBIsAoqgPO0+NZzghhJ6OE0tglHAUQ2I0GpTKQ7UVWnnxW+F0VS wD3uh7mqtTIfjYjmyQYySAEBao8vX4nlSglejW2ROg50mtetNMo3twpwLWCHpKb+DE M/YFrtjhFFZi8ud2ND0qM/pb/gqptks9QyaLtvg+GcjCns1rrh1nB+SU4HGErUJrcz 2lnKf6KEC2/qTrN5G92H9XM4Rmou+e1OndATke8ouPAOgUZ5NR5iYTsTvGwRU1M3mj akgjZKeOSlHGA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 2/2] dmaengine: shdma: increase size of 'dev_id' Date: Mon, 29 Jan 2024 13:36:31 -0500 Message-ID: <20240129183633.464847-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240129183633.464847-1-sashal@kernel.org> References: <20240129183633.464847-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.306 Content-Transfer-Encoding: 8bit From: Vinod Koul [ Upstream commit 404290240827c3bb5c4e195174a8854eef2f89ac ] We seem to have hit warnings of 'output may be truncated' which is fixed by increasing the size of 'dev_id' drivers/dma/sh/shdmac.c: In function ‘sh_dmae_probe’: drivers/dma/sh/shdmac.c:541:34: error: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 9 [-Werror=format-truncation=] 541 | "sh-dmae%d.%d", pdev->id, id); | ^~ In function ‘sh_dmae_chan_probe’, inlined from ‘sh_dmae_probe’ at drivers/dma/sh/shdmac.c:845:9: drivers/dma/sh/shdmac.c:541:26: note: directive argument in the range [0, 2147483647] 541 | "sh-dmae%d.%d", pdev->id, id); | ^~~~~~~~~~~~~~ drivers/dma/sh/shdmac.c:541:26: note: directive argument in the range [0, 19] drivers/dma/sh/shdmac.c:540:17: note: ‘snprintf’ output between 11 and 21 bytes into a destination of size 16 540 | snprintf(sh_chan->dev_id, sizeof(sh_chan->dev_id), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 541 | "sh-dmae%d.%d", pdev->id, id); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/sh/shdma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sh/shdma.h b/drivers/dma/sh/shdma.h index 2c0a969adc9f..35987a35a848 100644 --- a/drivers/dma/sh/shdma.h +++ b/drivers/dma/sh/shdma.h @@ -29,7 +29,7 @@ struct sh_dmae_chan { const struct sh_dmae_slave_config *config; /* Slave DMA configuration */ int xmit_shift; /* log_2(bytes_per_xfer) */ void __iomem *base; - char dev_id[16]; /* unique name per DMAC of channel */ + char dev_id[32]; /* unique name per DMAC of channel */ int pm_error; dma_addr_t slave_addr; }; -- 2.43.0