From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15646155A33; Tue, 30 Jan 2024 18:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706638735; cv=none; b=pELz4IdROu9ZlRxdQkokFoi+f8HjpSBfmEqWjxw8S55IqEx+4q5JuzNItz/ldl91r/KMBj2fDJzGuksuyhQqcHIlllqhctsZABI56pcVASx2j2Lj5kh9aYftO+rkkr6CU1BqwphkuxE9pJR88ME417DaxYf/gkihNNc4Asnb8x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706638735; c=relaxed/simple; bh=PjrgU25A2IyPMYtXC01U7AtGDTIv3s/p7Yxp4fnNn1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YMo/8FpfSNfRC4n17fo1gVkalfQYFGneoCQs1PhJdHOrdqbk2W87BoInBdV2+VY2sibGr/Eim6ors7BQDVQuk/lDe+oK4KDZYwMrpOeiUHq6V3qVKY3wXozZ5xlfq6OYgQkqSF3s69mkIUdWk5+0JAd+apHMX+faSUMqi/zhmSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jg5rqK62; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jg5rqK62" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E1DDC433C7; Tue, 30 Jan 2024 18:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706638734; bh=PjrgU25A2IyPMYtXC01U7AtGDTIv3s/p7Yxp4fnNn1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jg5rqK6279YfSzKAR1sZHIUwGBdewBi2js96OhWqlbDh192UiiugY1LcKTFvFPWiY xa9/Q9WWBx4OIYBULA8jJ1cUtscgsUnSLfau93NItGxxMf8kbCA9yxDKZHPQ1YYU+W WmqDeYDOSDA9MyONG8RfrACX0JcroXhi8aCHu/ZYGxEVTfA+zrvg82zajlIpugPOri dL72iJZQ7owNDRpmnmrxWwKZn2ONNv5bpGEPxaKN2TrK+qGRTWKHmPk2/IcdxoRqzZ +1MGIeEl2e6HF2Yg1jTfcWFtIFrJqyzq8O7xSEvJDllKzpdMQeuwUjVQIuSvs/voJF 4x/WGeh3mLu5A== Date: Tue, 30 Jan 2024 18:18:49 +0000 From: Conor Dooley To: Johan Jonker Cc: robh+dt@kernel.org, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, mripard@kernel.org, markyao0591@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property Message-ID: <20240130-denim-capacity-e1617595ac9f@spud> References: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Se7db1/EZ7/Uf0wV" Content-Disposition: inline In-Reply-To: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com> --Se7db1/EZ7/Uf0wV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 30, 2024 at 03:55:43PM +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi nodes with, so deprecate the port property and This doesn't really explain what makes having hdmi-connector nodes replace the usecase for "port". > make port@0 and > port@1 a requirement. Why? > Also update example. "Also do x" is a red flag when it comes to commit messages, as it immediately makes me think that this should be more than one commit. I'd probably write this as "Update the example to avoid use of the deprecated property" or something to avoid bad gut reactions. That's not worth resending for though obviously... >=20 > Signed-off-by: Johan Jonker > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 27 ++++++++++++++++--- > 1 file changed, 23 insertions(+), 4 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,= dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,= dw-hdmi.yaml > index 7e59dee15a5f..cd0a42f35f24 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi= =2Eyaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi= =2Eyaml > @@ -97,8 +97,11 @@ properties: > ports: > $ref: /schemas/graph.yaml#/properties/ports >=20 > - patternProperties: > - "^port(@0)?$": > + properties: > + port: > + $ref: /schemas/graph.yaml#/properties/port > + deprecated: true This change makes the deprecated property's description incomplete, since it doesn't cover the endpoints any more. It also doesn't make port@0 and port mutually exclusive. I think I'd just be inclined to delete the "port" bit entirely from the binding if you're not gonna preserve the description of what that property was meant to be. Otherwise, I'd be doing something like: @@ -112,6 +112,8 @@ properties: endpoint@1: description: Connection to the VOPL properties: + port: + deprecated: true port@1: $ref: /schemas/graph.yaml#/properties/port description: Output of the DWC HDMI TX So that the description of the deprecated property is maintained. Cheers, Conor. > + port@0: > $ref: /schemas/graph.yaml#/properties/port > description: Input of the DWC HDMI TX > properties: > @@ -108,11 +111,14 @@ properties: > description: Connection to the VOPB > endpoint@1: > description: Connection to the VOPL > - properties: > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: Output of the DWC HDMI TX >=20 > + required: > + - port@0 > + - port@1 > + > rockchip,grf: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -147,7 +153,11 @@ examples: > clock-names =3D "iahb", "isfr"; >=20 > ports { > - port { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > #address-cells =3D <1>; > #size-cells =3D <0>; >=20 > @@ -155,11 +165,20 @@ examples: > reg =3D <0>; > remote-endpoint =3D <&vopb_out_hdmi>; > }; > + > hdmi_in_vopl: endpoint@1 { > reg =3D <1>; > remote-endpoint =3D <&vopl_out_hdmi>; > }; > }; > + > + port@1 { > + reg =3D <1>; > + > + hdmi_out_con: endpoint { > + remote-endpoint =3D <&hdmi_con_in>; > + }; > + }; > }; > }; >=20 > -- > 2.39.2 >=20 --Se7db1/EZ7/Uf0wV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbk9iAAKCRB4tDGHoIJi 0ov4AQC/D1c0VhrC43ss+Gx+M3QV8KxYk6PBwCzFXmE5ODySRQEA9bUSt6oR5ZHe QvmugJnjTjCAnylB7d4Ml9YpiJeaEAU= =pq3u -----END PGP SIGNATURE----- --Se7db1/EZ7/Uf0wV--