From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A80B605B6 for ; Tue, 30 Jan 2024 09:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706608191; cv=none; b=LlTrwDPjQLnYiQNnMRDCV8cMToWpr0MOS3FBeAz0hBeEa6LbMeqgGaf8JwtQBTkEXEtVM/AVnQOQ7T7ZqTiywnKXmw+nYJFxE7bZjmB5PYjiuJLXM6BSDy3WKO7xDX4oBXvMt43hARLV20jNsB0ZuyF8ZxvmfgteZ8wv4H6rW/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706608191; c=relaxed/simple; bh=F1bKkLvaSj5vu8qpwe9u9hc2vcLDAGo+kkKRhvziS/0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uPyb9xJPcxSVRpCZHQ1yr/KiVNRprrjR5P94PdwOmMltwn7Kg7x9D0sONHMtFKb9Jj7RdlZmjRQJxp6reg2lpgcRPJvDFbdG22mUVOU2tZce8y9jRaIsAq0RYGmOgwKqd2Ot4XO0TdEJnW9o3akSCFMSghTKhkWWXYMeCl3qS7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Z5Yx1iiC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=us3GJlEw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Z5Yx1iiC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=us3GJlEw; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z5Yx1iiC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="us3GJlEw"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z5Yx1iiC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="us3GJlEw" Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B337F1F841; Tue, 30 Jan 2024 09:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706608187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NWnp6jiMMzTOot4gN/xZQyWbHCyYI7lT4iVyNeo9e2M=; b=Z5Yx1iiC/mBJaW/gldGKjtiTC1Nopfg9iL9FuJqOALvYlTyYLlZWf+nc+c3hEna9Zjs/Ch EwrOzkdBcoCGvgHnnkqSQuxiNEr4rHuqS4/cVtVn9IyH5OmSV5QTH0c0XdAjRn6rqd2M2/ 8WEcGgQQEon51CXPrv5T5Vagrlw4dSk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706608187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NWnp6jiMMzTOot4gN/xZQyWbHCyYI7lT4iVyNeo9e2M=; b=us3GJlEwaluiOuAvpvuSZgVLViIBQr5H+pOmDnfMQU9Iwk9WTawScoUDTAHd0qBKEBWpEe upCL0aXt6JHU28Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706608187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NWnp6jiMMzTOot4gN/xZQyWbHCyYI7lT4iVyNeo9e2M=; b=Z5Yx1iiC/mBJaW/gldGKjtiTC1Nopfg9iL9FuJqOALvYlTyYLlZWf+nc+c3hEna9Zjs/Ch EwrOzkdBcoCGvgHnnkqSQuxiNEr4rHuqS4/cVtVn9IyH5OmSV5QTH0c0XdAjRn6rqd2M2/ 8WEcGgQQEon51CXPrv5T5Vagrlw4dSk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706608187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NWnp6jiMMzTOot4gN/xZQyWbHCyYI7lT4iVyNeo9e2M=; b=us3GJlEwaluiOuAvpvuSZgVLViIBQr5H+pOmDnfMQU9Iwk9WTawScoUDTAHd0qBKEBWpEe upCL0aXt6JHU28Cw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id A00F413462; Tue, 30 Jan 2024 09:49:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id j0irJTvGuGWCbwAAn2gu4w (envelope-from ); Tue, 30 Jan 2024 09:49:47 +0000 From: Daniel Wagner To: James Smart Cc: Keith Busch , Christoph Hellwig , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner Subject: [PATCH v4 00/12] enable nvmet-fc for blktests Date: Tue, 30 Jan 2024 10:49:26 +0100 Message-ID: <20240130094938.1575-1-dwagner@suse.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [4.90 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: **** X-Spam-Score: 4.90 X-Spam-Flag: NO The first version which allows to run blktests in loop without crashing or hanging forever somewhere. The missing fix was the argument swap patch for list_add_tail, which ensured no response gets dropped on tbe floor. Note, this runs with the udev auto connect rule running in the background which injects a lot of additional noise to the test. For example blktests will warn about 'device not removed', which is correct but this device was not created by the test, it was created by the udev rule. nvme/003 fails because it disconnects two devices instead the exptected one. These are things we have to address in blktests though. So hopefully with these patches we are getting close to run blktests on a regular basis. changes: v4: - dropped patches which got applied - dropped 'nvmet-fc: free hostport after release reference to tgtport' - reworked commit message of 'nvmet-fc: untangle cross refcounting objects' and renamed it to 'nvmet-fc: defer cleanup using RCU properly' - added 'nvmet-fcloop: swap the list_add_tail arguments' and 'nvmet-fc: use RCU list iterator for assoc_list' - added RBs v3: - collected all patches into one series - updated ref counting in nvmet-fc v2: - added RBs - added new patches - https://lore.kernel.org/linux-nvme/20230620133711.22840-1-dwagner@suse.de/ v1: - https://lore.kernel.org/linux-nvme/20230615094356.14878-1-dwagner@suse.de/ *** BLURB HERE *** Daniel Wagner (12): nvme-fc: do not wait in vain when unloading module nvmet-fcloop: swap the list_add_tail arguments nvmet-fc: release reference on target port nvmet-fc: defer cleanup using RCU properly nvmet-fc: free queue and assoc directly nvmet-fc: hold reference on hostport match nvmet-fc: remove null hostport pointer check nvmet-fc: do not tack refs on tgtports from assoc nvmet-fc: abort command when there is no binding nvmet-fc: avoid deadlock on delete association path nvmet-fc: take ref count on tgtport before delete assoc nvmet-fc: use RCU list iterator for assoc_list drivers/nvme/host/fc.c | 47 ++--------- drivers/nvme/target/fc.c | 156 +++++++++++++++++++---------------- drivers/nvme/target/fcloop.c | 6 +- 3 files changed, 93 insertions(+), 116 deletions(-) -- 2.43.0