From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jian-Hong Pan <jhp@endlessos.org>
Cc: David Box <david.e.box@linux.intel.com>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Nirmal Patel <nirmal.patel@linux.intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>,
linux-ide@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessos.org
Subject: Re: [PATCH 1/2] ata: ahci: Add force LPM policy quirk for ASUS B1400CEAE
Date: Tue, 30 Jan 2024 12:13:35 +0200 [thread overview]
Message-ID: <20240130101335.GU2543524@black.fi.intel.com> (raw)
In-Reply-To: <20240130095933.14158-1-jhp@endlessos.org>
Hi,
On Tue, Jan 30, 2024 at 05:59:33PM +0800, Jian-Hong Pan wrote:
> Some systems, like ASUS B1400CEAE equipped with the SATA controller
> [8086:a0d3] can use LPM policy to save power, especially for s2idle.
>
> However, the same controller may be failed on other platforms. So,
> commit (ata: ahci: Revert "ata: ahci: Add Tiger Lake UP{3,4} AHCI
> controller") drops LPM policy for [8086:a0d3]. But, this blocks going
> to deeper CPU Package C-state when s2idle with enabled Intel VMD.
Tiger Lake really should support this with no issues (as are the
generations after it). I suggest trying to figure out what was the root
cause of the original problem that triggered the revert, if possible at
all, perhaps it is is something not related to LPM and that would allow
us to enable this unconditionally on all Tiger Lake.
I'm pretty sure the platform where this was reported suffers the same
s2idle issue you are seeing without this patch.
next prev parent reply other threads:[~2024-01-30 10:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:59 [PATCH 1/2] ata: ahci: Add force LPM policy quirk for ASUS B1400CEAE Jian-Hong Pan
2024-01-30 10:13 ` Mika Westerberg [this message]
2024-01-31 8:56 ` Jian-Hong Pan
2024-01-31 10:57 ` Niklas Cassel
2024-01-31 11:08 ` Daniel Drake
2024-01-31 22:43 ` Niklas Cassel
[not found] ` <CADMpKLrNmmQ3PRTsiDXWBQ6iiJ9F+93xEk6HpuuK4Ev=n-i7wA@mail.gmail.com>
2024-02-01 10:35 ` Niklas Cassel
2024-02-01 15:01 ` Niklas Cassel
2024-02-02 8:49 ` Jian-Hong Pan
2024-02-05 11:33 ` Niklas Cassel
2024-02-06 8:39 ` Jian-Hong Pan
2024-02-06 13:12 ` Niklas Cassel
2024-02-06 22:07 ` Niklas Cassel
2024-02-07 6:35 ` Jian-Hong Pan
2024-02-07 6:31 ` Jian-Hong Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130101335.GU2543524@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=cassel@kernel.org \
--cc=david.e.box@linux.intel.com \
--cc=dlemoal@kernel.org \
--cc=jhp@endlessos.org \
--cc=jonathan.derrick@linux.dev \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@endlessos.org \
--cc=nirmal.patel@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox