Re: [PATCH v2 2/7] firmware: coreboot: Generate aliases for coreboot modules

Greg Kroah-Hartman
2024-01-30T23:51:28Z

On Tue, Jan 23, 2024 at 02:06:14PM -0800, Brian Norris wrote:
> On Sun, Jan 14, 2024 at 07:09:29PM +0200, Andy Shevchenko wrote:
> > On Fri, Jan 12, 2024 at 10:18:31AM -0300, Nícolas F. R. A. Prado wrote:
> > > Generate aliases for coreboot modules to allow automatic module probing.
> >
> > ...
> >
> > > (no changes since v1)
> >
> > Same Q as per v1.
>
> I don't have v1 in my inbox, and this wasn't addressed in v3 either. But
> copy/pasted off the archives:
>
> "Don't you want to have a driver data or so associated with this?"
>
> These drivers are super simple, and I doubt they will end up with
> multiple tags per driver, so it seems unlikely we'd ever need it.
> Additionally, struct coreboot_device already includes the tag
> information, so anything that could be included in driver data could be
> parsed out by the driver at probe time, if absolutely needed.

But why limit yourself to 32bits now? Why not make it 64? It is going
to be sent to userspace, so you have to be very careful about it.

thanks,

greg k-h