Re: [PATCH v2] dt-bindings: iio: afe: voltage-divider: Add io-channel-cells

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Tue, 30 Jan 2024 17:18:53 +0530
Naresh Solanki <naresh.solanki@9elements.com> wrote:

> Hi Peter,
> 
> 
> On Tue, 30 Jan 2024 at 17:12, Peter Rosin <peda@axentia.se> wrote:
> >
> > Hi!
> >
> > 2024-01-30 at 12:18, Naresh Solanki wrote:  
> > > voltage-divider is always an iio consumer at the same time it is
> > > optionally an iio provider.
> > > Hence add #io-channel-cells
> > > Also update example.
> > >
> > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > > ---
> > >  .../bindings/iio/afe/voltage-divider.yaml          | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> > > index dddf97b50549..09f10d7c4e02 100644
> > > --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> > > @@ -39,6 +39,13 @@ properties:
> > >      description: |
> > >        Channel node of a voltage io-channel.
> > >
> > > +  '#io-channel-cells':
> > > +    description:
> > > +      In addition to consuming the measurement services of an ADC,  
> >
> > It doesn't really need to be an ADC. Anything with a voltage output
> > channel works (in theory). But sure, normally it would be an ADC...  
> Ack
> >  
> > > +      the voltage divider can act as an provider of measurement  
> >
> > a provider  
> Ack
> 
> Will update as:
>   '#io-channel-cells':
>     description:
>       In addition to consuming the measurement services of an a voltage output

That sounds like a DAC.  It's an input voltage to that device.
Just go with voltage channel and rely on measurement services to make it clear what
it is.

>       channel the voltage divider can act as a provider of measurement
>       services to other devices.
>     const: 1
> 
> Regards,
> Naresh
> >
> > Cheers,
> > Peter
> >  
> > > +      services to other devices.
> > > +    const: 1
> > > +
> > >    output-ohms:  
> > ...  
>