From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: mka@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 5/7] net: ipa: kill ipa_power_modem_queue_stop()
Date: Tue, 30 Jan 2024 13:23:02 -0600 [thread overview]
Message-ID: <20240130192305.250915-6-elder@linaro.org> (raw)
In-Reply-To: <20240130192305.250915-1-elder@linaro.org>
All ipa_power_modem_queue_stop() does now is call netif_stop_queue().
Just call netif_stop_queue() in the one place it's needed, and get
rid of ipa_power_modem_queue_stop().
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_modem.c | 2 +-
drivers/net/ipa/ipa_power.c | 16 +++++-----------
drivers/net/ipa/ipa_power.h | 6 ------
3 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c
index c7a0b167c4326..08e1202f12863 100644
--- a/drivers/net/ipa/ipa_modem.c
+++ b/drivers/net/ipa/ipa_modem.c
@@ -156,7 +156,7 @@ ipa_start_xmit(struct sk_buff *skb, struct net_device *netdev)
* we restart queueing before transmitting the SKB. Otherwise
* queueing will eventually be enabled after resume completes.
*/
- ipa_power_modem_queue_stop(ipa);
+ netif_stop_queue(netdev);
dev = &ipa->pdev->dev;
ret = pm_runtime_get(dev);
diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c
index e615473d23805..812359c7977da 100644
--- a/drivers/net/ipa/ipa_power.c
+++ b/drivers/net/ipa/ipa_power.c
@@ -227,7 +227,7 @@ void ipa_power_suspend_handler(struct ipa *ipa, enum ipa_irq_id irq_id)
ipa_interrupt_suspend_clear_all(ipa->interrupt);
}
-/* The next few functions are used when stopping and starting the modem
+/* The next two functions are used when stopping and starting the modem
* network device transmit queue.
*
* Transmit can run concurrent with power resume. When transmitting,
@@ -236,17 +236,11 @@ void ipa_power_suspend_handler(struct ipa *ipa, enum ipa_irq_id irq_id)
* gets sent (or dropped). If power is not ACTIVE, it will eventually
* be, and transmits stay disabled until after it is.
*
- * The first function stops the modem netdev transmit queue. The second
- * function starts the transmit queue and is used in the power resume
- * path after power has become ACTIVE. The third function also enables
- * transmits again, and is used by ipa_start_xmit() once it knows power
- * is active.
+ * The first function starts the transmit queue and is used in the power
+ * resume path after power has become ACTIVE. The second function also
+ * enables transmits again, and is used by ipa_start_xmit() once it
+ * knows power is active.
*/
-void ipa_power_modem_queue_stop(struct ipa *ipa)
-{
- netif_stop_queue(ipa->modem_netdev);
-}
-
void ipa_power_modem_queue_wake(struct ipa *ipa)
{
netif_wake_queue(ipa->modem_netdev);
diff --git a/drivers/net/ipa/ipa_power.h b/drivers/net/ipa/ipa_power.h
index 3a4c59ea1222b..f51653399a07d 100644
--- a/drivers/net/ipa/ipa_power.h
+++ b/drivers/net/ipa/ipa_power.h
@@ -23,12 +23,6 @@ extern const struct dev_pm_ops ipa_pm_ops;
*/
u32 ipa_core_clock_rate(struct ipa *ipa);
-/**
- * ipa_power_modem_queue_stop() - Possibly stop the modem netdev TX queue
- * @ipa: IPA pointer
- */
-void ipa_power_modem_queue_stop(struct ipa *ipa);
-
/**
* ipa_power_modem_queue_wake() - Possibly wake the modem netdev TX queue
* @ipa: IPA pointer
--
2.40.1
next prev parent reply other threads:[~2024-01-30 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 19:22 [PATCH net-next 0/7] net: ipa: simplify TX power handling Alex Elder
2024-01-30 19:22 ` [PATCH net-next 1/7] net: ipa: stash modem TX and RX endpoints Alex Elder
2024-01-30 19:22 ` [PATCH net-next 2/7] net: ipa: begin simplifying TX queue stop Alex Elder
2024-01-30 19:23 ` [PATCH net-next 3/7] net: ipa: kill the STARTED IPA power flag Alex Elder
2024-01-30 19:23 ` [PATCH net-next 4/7] net: ipa: kill the IPA power STOPPED flag Alex Elder
2024-01-30 19:23 ` Alex Elder [this message]
2024-01-30 19:23 ` [PATCH net-next 6/7] net: ipa: kill ipa_power_modem_queue_active() Alex Elder
2024-01-30 19:23 ` [PATCH net-next 7/7] net: ipa: kill ipa_power_modem_queue_wake() Alex Elder
2024-02-02 5:00 ` [PATCH net-next 0/7] net: ipa: simplify TX power handling patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130192305.250915-6-elder@linaro.org \
--to=elder@linaro.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox