From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: [PATCH 6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments
Date: Tue, 30 Jan 2024 10:46:32 -0800 [thread overview]
Message-ID: <2024013031-tranquil-matador-a554@gregkh> (raw)
In-Reply-To: <2024013025-spoiling-exact-ad20@gregkh>
Now that we manually created our own attribute group list, the outdated
ATTRIBUTE_GROUPS() comments can be removed as they are not needed at
all.
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Sanyog Kale <sanyog.r.kale@intel.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/soundwire/sysfs_slave.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c
index 0eefc205f697..f4259710dd0f 100644
--- a/drivers/soundwire/sysfs_slave.c
+++ b/drivers/soundwire/sysfs_slave.c
@@ -129,10 +129,6 @@ static struct attribute *slave_dev_attrs[] = {
NULL,
};
-/*
- * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory
- * for device-level properties
- */
static const struct attribute_group sdw_slave_dev_attr_group = {
.attrs = slave_dev_attrs,
.name = "dev-properties",
@@ -204,10 +200,6 @@ static bool dp0_group_visible(struct kobject *kobj)
}
DEFINE_SYSFS_GROUP_VISIBLE(dp0);
-/*
- * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory
- * for dp0-level properties
- */
static const struct attribute_group dp0_group = {
.attrs = dp0_attrs,
.is_visible = SYSFS_GROUP_VISIBLE(dp0),
--
2.43.0
next prev parent reply other threads:[~2024-01-30 18:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 18:46 [PATCH 0/7] Soundwire: clean up sysfs group creation Greg Kroah-Hartman
2024-01-30 18:46 ` [PATCH 1/6] sysfs: Introduce a mechanism to hide static attribute_groups Greg Kroah-Hartman
2024-01-31 13:05 ` Pierre-Louis Bossart
2024-01-31 16:30 ` Greg Kroah-Hartman
2024-01-31 18:08 ` Dan Williams
2024-01-31 19:43 ` Dan Williams
2024-01-30 18:46 ` [PATCH 2/6] soundwire: sysfs: move sdw_slave_dev_attr_group into the existing list of groups Greg Kroah-Hartman
2024-01-31 5:20 ` Dan Williams
2024-01-31 7:12 ` Pierre-Louis Bossart
2024-02-01 14:56 ` Greg Kroah-Hartman
2024-01-30 18:46 ` [PATCH 3/6] soundwire: sysfs: cleanup the logic for creating the dp0 sysfs attributes Greg Kroah-Hartman
2024-01-31 5:32 ` Dan Williams
2024-01-30 18:46 ` [PATCH 4/6] soundwire: sysfs: have the driver core handle the creation of the device groups Greg Kroah-Hartman
2024-01-31 5:37 ` Dan Williams
2024-01-30 18:46 ` [PATCH 5/6] soundwire: sysfs: remove sdw_slave_sysfs_init() Greg Kroah-Hartman
2024-01-31 5:39 ` Dan Williams
2024-01-30 18:46 ` Greg Kroah-Hartman [this message]
2024-01-31 5:41 ` [PATCH 6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments Dan Williams
2024-01-31 13:04 ` [PATCH 0/7] Soundwire: clean up sysfs group creation Vinod Koul
2024-03-27 8:13 ` Greg Kroah-Hartman
2024-03-27 12:51 ` Vinod Koul
2024-03-28 12:23 ` Mukunda,Vijendar
2024-03-28 18:15 ` (subset) " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024013031-tranquil-matador-a554@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox