From: Max Kellermann <max.kellermann@ionos.com>
To: linux-kernel@vger.kernel.org
Cc: Max Kellermann <max.kellermann@ionos.com>
Subject: [PATCH 11/28] percpu_counter.h: move declarations to percpu_counter_types.h
Date: Wed, 31 Jan 2024 15:49:51 +0100 [thread overview]
Message-ID: <20240131145008.1345531-12-max.kellermann@ionos.com> (raw)
In-Reply-To: <20240131145008.1345531-1-max.kellermann@ionos.com>
By providing declarations in a lean header, we can reduce header
dependencies.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
include/linux/backing-dev-defs.h | 2 +-
include/linux/flex_proportions.h | 2 +-
include/linux/ipc_namespace.h | 2 +-
include/linux/mm_types.h | 3 ++-
include/linux/percpu_counter.h | 17 +------------
include/linux/percpu_counter_types.h | 37 ++++++++++++++++++++++++++++
include/linux/sched/user.h | 2 +-
include/linux/shmem_fs.h | 2 +-
kernel/user.c | 1 +
lib/flex_proportions.c | 1 +
10 files changed, 47 insertions(+), 22 deletions(-)
create mode 100644 include/linux/percpu_counter_types.h
diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
index 68fdec049456..720a88bb3513 100644
--- a/include/linux/backing-dev-defs.h
+++ b/include/linux/backing-dev-defs.h
@@ -6,7 +6,7 @@
#include <linux/radix-tree.h>
#include <linux/rbtree_types.h>
#include <linux/spinlock_types.h>
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
#include <linux/percpu-refcount.h>
#include <linux/flex_proportions.h>
#include <linux/timer_types.h>
diff --git a/include/linux/flex_proportions.h b/include/linux/flex_proportions.h
index 35204b64addf..df9017a61046 100644
--- a/include/linux/flex_proportions.h
+++ b/include/linux/flex_proportions.h
@@ -8,7 +8,7 @@
#ifndef _LINUX_FLEX_PROPORTIONS_H
#define _LINUX_FLEX_PROPORTIONS_H
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
#include <linux/spinlock_types.h>
#include <linux/seqlock_types.h>
#include <linux/gfp_types.h>
diff --git a/include/linux/ipc_namespace.h b/include/linux/ipc_namespace.h
index a0011b6cd5d1..7c758ab565fe 100644
--- a/include/linux/ipc_namespace.h
+++ b/include/linux/ipc_namespace.h
@@ -11,7 +11,7 @@
#include <linux/refcount.h>
#include <linux/rhashtable-types.h>
#include <linux/sysctl.h>
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
struct user_namespace;
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 88bbb724080f..80d5a1762cca 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -17,7 +17,8 @@
#include <linux/page-flags-layout.h>
#include <linux/workqueue_types.h>
#include <linux/seqlock_types.h>
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
+#include <linux/percpu.h>
#include <asm/mmu.h>
diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index 8d45785b3448..bec5e7cdd476 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -7,26 +7,15 @@
* WARNING: these things are HUGE. 4 kbytes per counter on 32-way P4.
*/
-#include <linux/spinlock_types.h>
-#include <linux/list.h>
+#include <linux/percpu_counter_types.h>
#include <linux/threads.h>
#include <linux/percpu.h>
-#include <linux/types.h>
/* percpu_counter batch for local add or sub */
#define PERCPU_COUNTER_LOCAL_BATCH INT_MAX
#ifdef CONFIG_SMP
-struct percpu_counter {
- raw_spinlock_t lock;
- s64 count;
-#ifdef CONFIG_HOTPLUG_CPU
- struct list_head list; /* All percpu_counters are on a list */
-#endif
- s32 __percpu *counters;
-};
-
extern int percpu_counter_batch;
int __percpu_counter_init_many(struct percpu_counter *fbc, s64 amount,
@@ -131,10 +120,6 @@ static inline bool percpu_counter_initialized(struct percpu_counter *fbc)
#else /* !CONFIG_SMP */
-struct percpu_counter {
- s64 count;
-};
-
static inline int percpu_counter_init_many(struct percpu_counter *fbc,
s64 amount, gfp_t gfp,
u32 nr_counters)
diff --git a/include/linux/percpu_counter_types.h b/include/linux/percpu_counter_types.h
new file mode 100644
index 000000000000..faccd9869a5a
--- /dev/null
+++ b/include/linux/percpu_counter_types.h
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_PERCPU_COUNTER_TYPES_H
+#define _LINUX_PERCPU_COUNTER_TYPES_H
+/*
+ * A simple "approximate counter" for use in ext2 and ext3 superblocks.
+ *
+ * WARNING: these things are HUGE. 4 kbytes per counter on 32-way P4.
+ */
+
+#include <linux/types.h>
+
+#ifdef CONFIG_SMP
+
+#include <linux/spinlock_types.h>
+
+#ifdef CONFIG_HOTPLUG_CPU
+#include <linux/list.h>
+#endif
+
+struct percpu_counter {
+ raw_spinlock_t lock;
+ s64 count;
+#ifdef CONFIG_HOTPLUG_CPU
+ struct list_head list; /* All percpu_counters are on a list */
+#endif
+ s32 __percpu *counters;
+};
+
+#else /* !CONFIG_SMP */
+
+struct percpu_counter {
+ s64 count;
+};
+
+#endif /* CONFIG_SMP */
+
+#endif /* _LINUX_PERCPU_COUNTER_TYPES_H */
diff --git a/include/linux/sched/user.h b/include/linux/sched/user.h
index 671ecee08d23..913da0aba05c 100644
--- a/include/linux/sched/user.h
+++ b/include/linux/sched/user.h
@@ -4,7 +4,7 @@
#include <linux/uidgid_types.h>
#include <linux/atomic.h>
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
#include <linux/refcount.h>
#include <linux/ratelimit_types.h>
diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h
index 2caa6b86106a..1d7e56eab60f 100644
--- a/include/linux/shmem_fs.h
+++ b/include/linux/shmem_fs.h
@@ -6,7 +6,7 @@
#include <linux/swap.h>
#include <linux/mempolicy.h>
#include <linux/pagemap.h>
-#include <linux/percpu_counter.h>
+#include <linux/percpu_counter_types.h>
#include <linux/xattr.h>
#include <linux/fs_parser.h>
#include <linux/userfaultfd_k.h>
diff --git a/kernel/user.c b/kernel/user.c
index 28da71ea1e74..6c8b818419f8 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -22,6 +22,7 @@
#include <linux/proc_ns.h>
#include <linux/ratelimit.h>
#include <linux/uidgid.h>
+#include <linux/percpu_counter.h>
#if IS_ENABLED(CONFIG_BINFMT_MISC)
struct binfmt_misc init_binfmt_misc = {
diff --git a/lib/flex_proportions.c b/lib/flex_proportions.c
index 35784f94f0a7..967626b48bd0 100644
--- a/lib/flex_proportions.c
+++ b/lib/flex_proportions.c
@@ -34,6 +34,7 @@
* which something happened with proportion of type j.
*/
#include <linux/flex_proportions.h>
+#include <linux/percpu_counter.h>
#include <linux/math64.h>
#include <linux/seqlock.h>
--
2.39.2
next prev parent reply other threads:[~2024-01-31 14:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:49 [PATCH 00/28] Fast kernel headers: reduce header dependencies Max Kellermann
2024-01-31 14:49 ` [PATCH 01/28] include: add missing includes Max Kellermann
2024-01-31 14:49 ` [PATCH 02/28] include: remove unnecessary #include directives Max Kellermann
2024-02-02 23:58 ` kernel test robot
2024-01-31 14:49 ` [PATCH 03/28] include: reduce header dependencies by using "*_types.h" Max Kellermann
2024-01-31 14:49 ` [PATCH 04/28] workqueue.h: move struct delayed_work to workqueue_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 05/28] kref.h: move declarations to kref_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 06/28] kobject.h: move declarations to kobject_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 07/28] sysfs.h: move declarations to sysfs_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 08/28] maple_tree.h: move declarations to maple_tree_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 09/28] rwsem.h: move declarations to rwsem_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 10/28] uprobes.h: move declarations to uprobes_types.h Max Kellermann
2024-02-03 0:41 ` kernel test robot
2024-01-31 14:49 ` Max Kellermann [this message]
2024-01-31 14:49 ` [PATCH 12/28] bvec.h: move declarations to bvec_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 13/28] wait.h: move declarations to wait_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 14/28] swait.h: move declarations to swait_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 15/28] completion.h: move declarations to completion_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 16/28] device.h: move declarations to device_types.h Max Kellermann
2024-02-02 23:58 ` kernel test robot
2024-01-31 14:49 ` [PATCH 17/28] xarray.h: move declarations to xarray_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 18/28] blkdev.h: move blk_op_is_passthrough() to blk_types.h Max Kellermann
2024-01-31 14:49 ` [PATCH 19/28] bio.h: move bio_has_data() and bio_no_advance_iter() " Max Kellermann
2024-01-31 14:50 ` [PATCH 20/28] bio.h: move declarations to bio_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 21/28] percpu-refcount.h: move declarations to percpu-refcount_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 22/28] blkdev.h: move declarations to blkdev_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 23/28] sbitmap.h: move declarations to sbitmap_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 24/28] list_lru.h: move declarations to list_lru_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 25/28] list_bl.h: move declarations to list_bl_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 26/28] percpu-rwsem.h: move declarations to percpu-rwsem_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 27/28] quota.h: move declarations to quota_types.h Max Kellermann
2024-01-31 14:50 ` [PATCH 28/28] radix-tree.h: move declarations to radix-tree_types.h Max Kellermann
2024-01-31 21:44 ` [PATCH 00/28] Fast kernel headers: reduce header dependencies Randy Dunlap
2024-01-31 22:00 ` Max Kellermann
2024-02-01 18:08 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131145008.1345531-12-max.kellermann@ionos.com \
--to=max.kellermann@ionos.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox