From: Peter Hilber <peter.hilber@opensynergy.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Hilber <peter.hilber@opensynergy.com>,
Simon Horman <horms@kernel.org>,
"D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, "Dong,
Eddie" <eddie.dong@intel.com>,
"Hall, Christopher S" <christopher.s.hall@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH v3 1/8] x86/tsc: Fix major kernel-doc warnings for tsc.c
Date: Thu, 1 Feb 2024 02:04:46 +0100 [thread overview]
Message-ID: <20240201010453.2212371-2-peter.hilber@opensynergy.com> (raw)
In-Reply-To: <20240201010453.2212371-1-peter.hilber@opensynergy.com>
Fix the kernel-doc warnings which show up with default arguments for tsc.c:
$ ./scripts/kernel-doc arch/x86/kernel/tsc.c >/dev/null
arch/x86/kernel/tsc.c:1339: warning: Excess function parameter 'cycles' description in 'convert_art_ns_to_tsc'
arch/x86/kernel/tsc.c:1339: warning: Excess function parameter 'cs' description in 'convert_art_ns_to_tsc'
arch/x86/kernel/tsc.c:1373: warning: Function parameter or struct member 'work' not described in 'tsc_refine_calibration_work'
The first two warnings stem from members of the convert_art_ns_to_tsc()
return type (struct system_counterval_t). For convert_art_ns_to_tsc(),
the return type members are documented like parameters.
Since these members are already documented with the struct
system_counterval_t definition, remove the redundant documentation for
convert_art_ns_to_tsc(). This resolves the first two warnings.
Fix the third warning by appending a ':' instead of a '-' to the '@work'
documentation parameter.
Suggested-by: Simon Horman <horms@kernel.org>
Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
---
Notes:
v3: Added on suggestion of Simon Horman.
arch/x86/kernel/tsc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index d45084c6a15e..42328f9653c1 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -1329,10 +1329,6 @@ EXPORT_SYMBOL(convert_art_to_tsc);
* Return:
* struct system_counterval_t - system counter value with the pointer to the
* corresponding clocksource
- * @cycles: System counter value
- * @cs: Clocksource corresponding to system counter value. Used
- * by timekeeping code to verify comparability of two cycle
- * values.
*/
struct system_counterval_t convert_art_ns_to_tsc(u64 art_ns)
@@ -1357,7 +1353,7 @@ static void tsc_refine_calibration_work(struct work_struct *work);
static DECLARE_DELAYED_WORK(tsc_irqwork, tsc_refine_calibration_work);
/**
* tsc_refine_calibration_work - Further refine tsc freq calibration
- * @work - ignored.
+ * @work: ignored.
*
* This functions uses delayed work over a period of a
* second to further refine the TSC freq value. Since this is
--
2.40.1
next prev parent reply other threads:[~2024-02-01 1:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 1:04 [PATCH v3 0/8] treewide: Use clocksource ID for get_device_system_crosststamp() Peter Hilber
2024-02-01 1:04 ` Peter Hilber [this message]
2024-02-01 4:52 ` [PATCH v3 1/8] x86/tsc: Fix major kernel-doc warnings for tsc.c Randy Dunlap
2024-02-06 10:54 ` Peter Hilber
2024-02-06 20:34 ` Randy Dunlap
2024-02-01 1:04 ` [PATCH v3 2/8] timekeeping: Add clocksource ID to struct system_counterval_t Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 3/8] x86/tsc: Add clocksource ID, set system_counterval_t.cs_id Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 4/8] x86/kvm, ptp/kvm: " Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 5/8] ptp/kvm, arm_arch_timer: Set system_counterval_t.cs_id to constant Peter Hilber
2024-02-01 13:52 ` Marc Zyngier
2024-02-01 14:04 ` Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 6/8] timekeeping: Evaluate system_counterval_t.cs_id instead of .cs Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 7/8] treewide: Remove system_counterval_t.cs, which is never read Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 8/8] kvmclock: Unexport kvmclock clocksource Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201010453.2212371-2-peter.hilber@opensynergy.com \
--to=peter.hilber@opensynergy.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=christopher.s.hall@intel.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=eddie.dong@intel.com \
--cc=giometti@enneenne.com \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=jstultz@google.com \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox