Re: [PATCH kernel 1/4] pci/doe: Define protocol types and make those public

Bjorn Helgaas
2024-02-08T21:57:37Z

On Thu, Feb 01, 2024 at 05:02:25PM +1100, Alexey Kardashevskiy wrote:
> Already public pci_doe() takes a protocol type argument.
> PCIe 6.0 defines three, define them in a header for use with pci_doe().
>
> Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
> ---
> include/linux/pci-doe.h | 4 ++++
> drivers/pci/doe.c | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/pci-doe.h b/include/linux/pci-doe.h
> index 1f14aed4354b..5c33f7dc978b 100644
> --- a/include/linux/pci-doe.h
> +++ b/include/linux/pci-doe.h
> @@ -13,6 +13,10 @@
> #ifndef LINUX_PCI_DOE_H
> #define LINUX_PCI_DOE_H
>
> +#define PCI_DOE_PROTOCOL_DISCOVERY 0
> +#define PCI_DOE_PROTOCOL_CMA_SPDM 1
> +#define PCI_DOE_PROTOCOL_SECURED_CMA_SPDM 2

So far these are only needed inside drivers/pci/. I don't want to
expose them to the rest of the kernel via include/linux/pci-doe.h
until they're needed elsewhere.

> struct pci_doe_mb;
>
> struct pci_doe_mb *pci_find_doe_mailbox(struct pci_dev *pdev, u16 vendor,
> diff --git a/drivers/pci/doe.c b/drivers/pci/doe.c
> index e3aab5edaf70..61f0531d2b1d 100644
> --- a/drivers/pci/doe.c
> +++ b/drivers/pci/doe.c
> @@ -22,8 +22,6 @@
>
> #include "pci.h"
>
> -#define PCI_DOE_PROTOCOL_DISCOVERY 0
> -
> /* Timeout of 1 second from 6.30.2 Operation, PCI Spec r6.0 */
> #define PCI_DOE_TIMEOUT HZ
> #define PCI_DOE_POLL_INTERVAL (PCI_DOE_TIMEOUT / 128)
> --
> 2.41.0
>