public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Alexey Kardashevskiy <aik@amd.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH kernel 1/4] pci/doe: Define protocol types and make those public
Date: Thu, 1 Feb 2024 07:50:40 +0100	[thread overview]
Message-ID: <20240201065040.GA31925@wunner.de> (raw)
In-Reply-To: <20240201060228.3070928-2-aik@amd.com>

On Thu, Feb 01, 2024 at 05:02:25PM +1100, Alexey Kardashevskiy wrote:
> Already public pci_doe() takes a protocol type argument.
> PCIe 6.0 defines three, define them in a header for use with pci_doe().
[...]
> --- a/include/linux/pci-doe.h
> +++ b/include/linux/pci-doe.h
> @@ -13,6 +13,10 @@
>  #ifndef LINUX_PCI_DOE_H
>  #define LINUX_PCI_DOE_H
>  
> +#define PCI_DOE_PROTOCOL_DISCOVERY		0
> +#define PCI_DOE_PROTOCOL_CMA_SPDM		1
> +#define PCI_DOE_PROTOCOL_SECURED_CMA_SPDM	2

These are deliberately defined in the .c files which actually need them,
i.e. DISCOVERY is defined in drivers/pci/doe.c and CMA_SPDM is defined in
drivers/pci/cma.c:

https://lore.kernel.org/all/7721bfa3b4f8a99a111f7808ad8890c3c13df56d.1695921657.git.lukas@wunner.de/

I don't see why they would have to be public if they're each only needed
in a single .c file.

Thanks,

Lukas

  reply	other threads:[~2024-02-01  6:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  6:02 [PATCH kernel 0/4] pci/doe/ide: Capabilities, protocols Alexey Kardashevskiy
2024-02-01  6:02 ` [PATCH kernel 1/4] pci/doe: Define protocol types and make those public Alexey Kardashevskiy
2024-02-01  6:50   ` Lukas Wunner [this message]
2024-02-01 10:16     ` Alexey Kardashevskiy
2024-02-09  8:52       ` Lukas Wunner
2024-02-15 11:44         ` Alexey Kardashevskiy
2024-02-08 21:57   ` Bjorn Helgaas
2024-02-01  6:02 ` [PATCH kernel 2/4] pci/doe: Support discovery version Alexey Kardashevskiy
2024-02-08 22:00   ` Bjorn Helgaas
2024-02-01  6:02 ` [PATCH kernel 3/4] pci: Define TEE-IO bit in PCIe device capabilities Alexey Kardashevskiy
2024-02-01  6:02 ` [PATCH kernel 4/4] pci: Define Integrity and Data Encryption (IDE) extended capability Alexey Kardashevskiy
2024-02-08 22:02   ` Bjorn Helgaas
2024-02-08 21:55 ` [PATCH kernel 0/4] pci/doe/ide: Capabilities, protocols Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201065040.GA31925@wunner.de \
    --to=lukas@wunner.de \
    --cc=aik@amd.com \
    --cc=bhelgaas@google.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox