From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: jikos@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members
Date: Thu, 1 Feb 2024 12:53:19 +0100 [thread overview]
Message-ID: <20240201115320.684-7-jirislaby@kernel.org> (raw)
In-Reply-To: <20240201115320.684-1-jirislaby@kernel.org>
struct pcmidi_snd contains two unused members: out_substream and
out_active. They were added along the driver in commit 3a370ca1dcf8
(HID: Prodikeys PC-MIDI HID Driver), but not used.
Drop them.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-prodikeys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index c16d2ba6ea16..439f4320f1d2 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -66,9 +66,7 @@ struct pcmidi_snd {
struct snd_card *card;
struct snd_rawmidi *rwmidi;
struct snd_rawmidi_substream *in_substream;
- struct snd_rawmidi_substream *out_substream;
unsigned long in_triggered;
- unsigned long out_active;
};
#define PK_QUIRK_NOGET 0x00010000
--
2.43.0
next prev parent reply other threads:[~2024-02-01 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
2024-02-14 12:54 ` Aditya Garg
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
2024-02-02 2:30 ` Ping Cheng
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
2024-02-01 11:53 ` Jiri Slaby (SUSE) [this message]
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201115320.684-7-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox