Re: [PATCH v6 1/6] dt-bindings: PCI: qcom: Add interconnects path as required property

Dmitry Baryshkov
2024-01-12T17:12:14Z

On Fri, 12 Jan 2024 at 18:55, Conor Dooley <conor@kernel.org> wrote:
>
> On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote:
> > Add the interconnects path as required property for sm8450 platform.
>
> There's no explaination here as to why you need two different
> compatibles for the instances on this device. Please add one.

Note, these are not new compatible strings. They are already defined
(separate because port0 and port1 have different sets of NoC clocks).

>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> > ---
> > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index eadba38171e1..bc28669f6fa0 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -777,6 +777,8 @@ allOf:
> > - qcom,pcie-sa8540p
> > - qcom,pcie-sa8775p
> > - qcom,pcie-sc8280xp
> > + - qcom,pcie-sm8450-pcie0
> > + - qcom,pcie-sm8450-pcie1
> > then:
> > required:
> > - interconnects
> >
> > --
> > 2.42.0
> >

--
With best wishes
Dmitry