From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Tycho Andersen <tycho@tycho.pizza>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open()
Date: Thu, 1 Feb 2024 19:10:07 +0100 [thread overview]
Message-ID: <20240201181006.GA31459@redhat.com> (raw)
In-Reply-To: <20240201-dokumentieren-holen-bc44288345b5@brauner>
On 02/01, Christian Brauner wrote:
>
> One more thing that came to my mind. We also support waitid(P_PIDFD,
> pidfd). And I just looked through the code and I think it does the right
> thing when we pass it a PIDFD_THREAD pidfd
Yes, I too looked into kernel_waitid_prepare(P_PIDFD) and didn't notice
anything wrong,
> because wait_consider_task()
Even simpler, I think. waitid(P_PIDFD, pidfd_with_PIDFD_THREAD) doesn't
really differ from waitid(P_PID, pidfd_pid(pidfd_with_PIDFD_THREAD)), so
it should work "as expected".
Oleg.
next prev parent reply other threads:[~2024-02-01 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 13:25 [PATCH v3 0/1] pidfd: implement PIDFD_THREAD flag for pidfd_open() Oleg Nesterov
2024-01-31 13:26 ` [PATCH v3 1/1] " Oleg Nesterov
2024-01-31 14:12 ` Christian Brauner
2024-01-31 14:19 ` Oleg Nesterov
2024-01-31 17:23 ` Tycho Andersen
2024-01-31 18:01 ` Oleg Nesterov
2024-01-31 18:15 ` Christian Brauner
2024-02-01 17:25 ` Christian Brauner
2024-02-01 18:10 ` Oleg Nesterov [this message]
2024-02-02 12:50 ` Christian Brauner
2024-02-05 15:22 ` Oleg Nesterov
2024-02-06 13:38 ` Christian Brauner
2024-02-08 7:54 ` kernel test robot
2024-02-08 8:58 ` Christian Brauner
2024-02-08 9:18 ` Oleg Nesterov
2024-01-31 13:58 ` [PATCH v3 0/1] " Christian Brauner
2024-01-31 14:12 ` Oleg Nesterov
2024-01-31 14:39 ` Christian Brauner
2024-01-31 16:10 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201181006.GA31459@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox