* [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST
@ 2024-02-01 22:11 Ivan Orlov
2024-02-02 8:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Orlov @ 2024-02-01 22:11 UTC (permalink / raw)
To: perex; +Cc: Ivan Orlov, linux-sound, linux-kernel
Select CONFIG_SND_PCM when enabling CONFIG_SND_CORE_TEST, as the test
uses symbols from 'pcm_misc.c'.
Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
---
V1 -> V2:
- Change 'depends' with 'select', as the user can't enable SND_PCM
explicitly.
- Add 'Fixes' tag since it is a regression fix.
sound/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..8077f481d84f 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
config SND_CORE_TEST
tristate "Sound core KUnit test"
depends on KUNIT
+ select SND_PCM
default KUNIT_ALL_TESTS
help
This options enables the sound core functions KUnit test.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST
2024-02-01 22:11 [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST Ivan Orlov
@ 2024-02-02 8:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-02-02 8:17 UTC (permalink / raw)
To: Ivan Orlov; +Cc: perex, linux-sound, linux-kernel
On Thu, 01 Feb 2024 23:11:22 +0100,
Ivan Orlov wrote:
>
> Select CONFIG_SND_PCM when enabling CONFIG_SND_CORE_TEST, as the test
> uses symbols from 'pcm_misc.c'.
>
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-02 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 22:11 [PATCH v2] ALSA: core: Fix dependencies for SND_CORE_TEST Ivan Orlov
2024-02-02 8:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox