public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH net 0/4] rxrpc: Miscellaneous fixes
Date: Fri,  2 Feb 2024 15:19:12 +0000	[thread overview]
Message-ID: <20240202151920.2760446-1-dhowells@redhat.com> (raw)

Here some miscellaneous fixes for AF_RXRPC:

 (1) The zero serial number has a special meaning in an ACK packet serial
     reference, so skip it when assigning serial numbers to transmitted
     packets.

 (2) Don't set the reference serial number in a delayed ACK as the ACK
     cannot be used for RTT calculation.

 (3) Don't emit a DUP ACK response to a PING RESPONSE ACK coming back to a
     call that completed in the meantime.

 (4) Fix the counting of acks and nacks in ACK packet to better drive
     congestion management.  We want to know if there have been new
     acks/nacks since the last ACK packet, not that there are still
     acks/nacks.  This is more complicated as we have to save the old SACK
     table and compare it.

David

---
The patches can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes

David Howells (4):
  rxrpc: Fix generation of serial numbers to skip zero
  rxrpc: Fix delayed ACKs to not set the reference serial number
  rxrpc: Fix response to PING RESPONSE ACKs to a dead call
  rxrpc: Fix counting of new acks and nacks

 include/trace/events/rxrpc.h |   8 ++-
 net/rxrpc/ar-internal.h      |  37 ++++++++---
 net/rxrpc/call_event.c       |  12 ++--
 net/rxrpc/call_object.c      |   1 +
 net/rxrpc/conn_event.c       |  10 ++-
 net/rxrpc/input.c            | 115 +++++++++++++++++++++++++++++------
 net/rxrpc/output.c           |   8 +--
 net/rxrpc/proc.c             |   2 +-
 net/rxrpc/rxkad.c            |   4 +-
 9 files changed, 154 insertions(+), 43 deletions(-)


             reply	other threads:[~2024-02-02 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 15:19 David Howells [this message]
2024-02-02 15:19 ` [PATCH net 1/4] rxrpc: Fix generation of serial numbers to skip zero David Howells
2024-02-02 15:19 ` [PATCH net 2/4] rxrpc: Fix delayed ACKs to not set the reference serial number David Howells
2024-02-02 15:19 ` [PATCH net 3/4] rxrpc: Fix response to PING RESPONSE ACKs to a dead call David Howells
2024-02-02 15:19 ` [PATCH net 4/4] rxrpc: Fix counting of new acks and nacks David Howells
2024-02-05 12:40 ` [PATCH net 0/4] rxrpc: Miscellaneous fixes patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 14:58 David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240202151920.2760446-1-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox