Re: [PATCH AUTOSEL 6.7 20/23] ARM: dts: Fix TPM schema violations

[Lukas Wunner <lukas@wunner.de>]

Hi Sasha,

On Fri, Feb 02, 2024 at 01:39:16PM -0500, Sasha Levin wrote:
> [ Upstream commit 8412c47d68436b9f9a260039a4a773daa6824925 ]
> 
> Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS
> bindings"), several issues are reported by "make dtbs_check" for ARM
> devicetrees:

You've auto-selected this commit for backporting to v6.6 and v6.7
stable kernels, but it's only really needed for v6.8 to avoid
issues reported by "make dtbs_check".

So IMO this commit can be dropped from the v6.6 and v6.7 patch queues.

Thanks,

Lukas

> The nodename needs to be "tpm@0" rather than "tpmdev@0" and the
> compatible property needs to contain the chip's name in addition to the
> generic "tcg,tpm_tis-spi" or "tcg,tpm-tis-i2c":
> 
>   tpmdev@0: $nodename:0: 'tpmdev@0' does not match '^tpm(@[0-9a-f]+)?$'
>         from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#
> 
>   tpm@2e: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['tcg,tpm-tis-i2c'] is too short
>         from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm-tis-i2c.yaml#
> 
> Fix these schema violations.