From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
"Le Ma" <le.ma@amd.com>, "André Almeida" <andrealmeid@igalia.com>,
"James Zhu" <James.Zhu@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Joerg Roedel" <jroedel@suse.de>,
"Iwona Winiarska" <iwona.winiarska@intel.com>,
"Robin Murphy" <robin.murphy@arm.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] driver core: bus: introduce can_remove()
Date: Fri, 2 Feb 2024 15:38:06 -0800 [thread overview]
Message-ID: <2024020224-unsoiled-velcro-86af@gregkh> (raw)
In-Reply-To: <20240202222603.141240-1-hamza.mahfooz@amd.com>
On Fri, Feb 02, 2024 at 05:25:54PM -0500, Hamza Mahfooz wrote:
> Currently, drivers have no mechanism to block requests to unbind
> devices.
And that is by design.
> However, this can cause resource leaks and leave the device in
> an inconsistent state, such that rebinding the device may cause a hang
> or otherwise prevent the device from being rebound.
That is a driver bug, please fix your driver.
> So, introduce the can_remove() callback to allow drivers to indicate
> if it isn't appropriate to remove a device at the given time.
Nope, sorry, the driver needs to be fixed.
What broken driver are you needing this for?
Also realize, only root can unbind drivers (and it can also unload
modules), so if the root user really wants to do this, it can, and
should be possible to.
sorry,
greg k-h
next prev parent reply other threads:[~2024-02-02 23:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 22:25 [PATCH 1/3] driver core: bus: introduce can_remove() Hamza Mahfooz
2024-02-02 22:25 ` [PATCH 2/3] PCI: " Hamza Mahfooz
2024-02-02 23:38 ` Greg Kroah-Hartman
2024-02-02 22:25 ` [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback Hamza Mahfooz
2024-02-02 22:41 ` Bjorn Helgaas
2024-02-02 23:40 ` Greg Kroah-Hartman
2024-02-06 14:29 ` Daniel Vetter
2024-02-06 18:42 ` Christian König
2024-02-09 11:00 ` Daniel Vetter
2024-02-02 23:41 ` Greg Kroah-Hartman
2024-02-02 23:38 ` Greg Kroah-Hartman [this message]
2024-02-05 8:48 ` [PATCH 1/3] driver core: bus: introduce can_remove() Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024020224-unsoiled-velcro-86af@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=James.Zhu@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=aurabindo.pillai@amd.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=iwona.winiarska@intel.com \
--cc=jroedel@suse.de \
--cc=le.ma@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srinivasan.shanmugam@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox