From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C217B11706 for ; Mon, 5 Feb 2024 07:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707118439; cv=none; b=jJ35iHGlJDpeE/ibMrzY7Q9gI3IaL+lAoHx2VsVBS/klR7X6r9mYTAxmRno3yfPKJYYuJkCGDD5t9kx9VsKWu50RlRKhy/2FbVtWfq2y2LlTwMJl0mJIZHCQYxLCfxvvQE6fp2dL8/zUY4j7CrM4Civl8+5vamVsdNVEP+4xL8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707118439; c=relaxed/simple; bh=PZulMIJuh1ibi1SJPAkqcIgNNrCSO8cnnWgsWRmhjP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oLPKZVTWtfDOcPmOIamUUZFAVQMvqU8Oq7OSEH39G+mgv/JGe6TWL4jjPzOT1NroEsx7V8MlZryhX5z3NtqGRjcma9gHmXv5vgsSKlNRIE7286fgadG/5qRjMioeWYLsySQNGU7gJx7wzc/PTjvbML6ywyO3lAbVuoQxFgIheIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ipqLXaQg; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ipqLXaQg" Received: from pendragon.ideasonboard.com (99.141-128-109.adsl-dyn.isp.belgacom.be [109.128.141.99]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B050667; Mon, 5 Feb 2024 08:32:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1707118353; bh=PZulMIJuh1ibi1SJPAkqcIgNNrCSO8cnnWgsWRmhjP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipqLXaQgog05Sd3Q4T6o8mINsn1EkTkQoJ9Hc55qxirusJr+cd2dIo4pKwdmDhU81 L9OSMcFCeIuyiHtiSdvw6vmDpSy5DfNYNJ6OxoC/daKEwI6Q1d3I/phfIuR5fL9i8B nhnzkgzeNN6gzrrRhV2b0FfKsLcL54U2MHKYuxnQ= Date: Mon, 5 Feb 2024 09:33:57 +0200 From: Laurent Pinchart To: Anatoliy Klymenko Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, michal.simek@amd.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] drm: xlnx: zynqmp_dpsub: Clear status register ASAP Message-ID: <20240205073357.GF6804@pendragon.ideasonboard.com> References: <20240124025402.373620-1-anatoliy.klymenko@amd.com> <20240124025402.373620-4-anatoliy.klymenko@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240124025402.373620-4-anatoliy.klymenko@amd.com> Hi Anatoliy, Thank you for the patch. On Tue, Jan 23, 2024 at 06:54:00PM -0800, Anatoliy Klymenko wrote: > Clear status register as soon as we read it. > > Addressing comments from > https://lore.kernel.org/dri-devel/beb551c7-bb7e-4cd0-b166-e9aad90c4620@ideasonboard.com/ > > Signed-off-by: Anatoliy Klymenko > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > index d60b7431603f..5a3335e1fffa 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > @@ -1624,6 +1624,8 @@ static irqreturn_t zynqmp_dp_irq_handler(int irq, void *data) > u32 status, mask; > > status = zynqmp_dp_read(dp, ZYNQMP_DP_INT_STATUS); > + /* clear status register as soon as we read it */ I don't think a comment is strictly required, but I don't mind it. Reviewed-by: Laurent Pinchart > + zynqmp_dp_write(dp, ZYNQMP_DP_INT_STATUS, status); > mask = zynqmp_dp_read(dp, ZYNQMP_DP_INT_MASK); > if (!(status & ~mask)) > return IRQ_NONE; > @@ -1634,8 +1636,6 @@ static irqreturn_t zynqmp_dp_irq_handler(int irq, void *data) > if (status & ZYNQMP_DP_INT_CHBUF_OVERFLW_MASK) > dev_dbg_ratelimited(dp->dev, "overflow interrupt\n"); > > - zynqmp_dp_write(dp, ZYNQMP_DP_INT_STATUS, status); > - > if (status & ZYNQMP_DP_INT_VBLANK_START) > zynqmp_dpsub_drm_handle_vblank(dp->dpsub); > -- Regards, Laurent Pinchart