From: Lee Jones <lee@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Li Zetao <lizetao1@huawei.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify
Date: Mon, 5 Feb 2024 14:27:35 +0000 [thread overview]
Message-ID: <20240205142735.GA53266@google.com> (raw)
In-Reply-To: <2cf84815-f9b6-4a0a-a3b4-d23628a89aa4@lunn.ch>
On Mon, 05 Feb 2024, Andrew Lunn wrote:
> > > This should have 'net' in the subject line, to indicate which tree its
> > > for.
> >
> > No, it shouldn't.
> >
> > Contributors aren't obliged to know anything about merging strategies.
>
> With netdev, we tend to assume they do, or at least can contribute to
> the discussion. They often know about any dependencies etc which could
> influence the decision. When there are multiple subsystem maintainers
> involved, i tend to use To: to indicate the maintainer i think should
> merge the patch, and Cc: for the rest.
This isn't a netdev patch. :)
We make no such stipulation for any of the subsystems I maintain.
The subject line should indicate which subsystem the commit pertains to,
not which maintainer will merge it or which tree it's merged via. In
this case, it's drivers/leds, so "leds: " is fine.
> > Why does this need to go in via net?
>
> It does not, as far as i'm aware. Christian, do you know of any
> reason?
It's pretty early in the cycle and there are no cross-subsystem deps
yet, as far as I'm aware.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-05 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 23:54 [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify Christian Marangi
2024-02-04 15:15 ` Andrew Lunn
2024-02-05 8:50 ` Lee Jones
2024-02-05 13:41 ` Andrew Lunn
2024-02-05 13:53 ` Christian Marangi
2024-02-05 14:33 ` Lee Jones
2024-02-05 14:38 ` Christian Marangi
2024-02-05 15:04 ` Lee Jones
2024-02-08 14:12 ` Lee Jones
2024-02-05 14:27 ` Lee Jones [this message]
2024-02-08 14:04 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205142735.GA53266@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox