* [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml
@ 2024-01-10 11:21 Zhenhua Huang
2024-01-10 19:19 ` Bjorn Andersson
2024-01-16 17:10 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Zhenhua Huang @ 2024-01-10 11:21 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: linux-mtd, devicetree, linux-kernel, quic_tingweiz, quic_bjorande,
Zhenhua Huang
The mtd binding is always $ref'ed by other bindings, default selector
should be from other binding files which ref'ed it. Now, "$nodename" in
mtd.yaml turns into a "select" automatically such that a few binding check
issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
rules in folder sram/*)
To avoid the automatically created "select" in mtd.yaml, adding:
select: false
Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
---
Hi Bjorn,
As the idea is from your comment, I added "Suggested-by" you.
Please tell me if that's not suitable. Thanks.
Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
index f322290..ee442ec 100644
--- a/Documentation/devicetree/bindings/mtd/mtd.yaml
+++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
@@ -10,6 +10,8 @@ maintainers:
- Miquel Raynal <miquel.raynal@bootlin.com>
- Richard Weinberger <richard@nod.at>
+select: false
+
properties:
$nodename:
pattern: "^(flash|.*sram|nand)(@.*)?$"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml
2024-01-10 11:21 [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml Zhenhua Huang
@ 2024-01-10 19:19 ` Bjorn Andersson
2024-01-16 17:10 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-01-10 19:19 UTC (permalink / raw)
To: Zhenhua Huang
Cc: miquel.raynal, richard, vigneshr, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-mtd, devicetree, linux-kernel, quic_tingweiz
On Wed, Jan 10, 2024 at 07:21:45PM +0800, Zhenhua Huang wrote:
> The mtd binding is always $ref'ed by other bindings, default selector
> should be from other binding files which ref'ed it. Now, "$nodename" in
> mtd.yaml turns into a "select" automatically such that a few binding check
> issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> rules in folder sram/*)
>
> To avoid the automatically created "select" in mtd.yaml, adding:
>
> select: false
>
> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> Hi Bjorn,
>
> As the idea is from your comment, I added "Suggested-by" you.
> Please tell me if that's not suitable. Thanks.
I appreciate that, thank you.
Regards,
Bjorn
>
> Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index f322290..ee442ec 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -10,6 +10,8 @@ maintainers:
> - Miquel Raynal <miquel.raynal@bootlin.com>
> - Richard Weinberger <richard@nod.at>
>
> +select: false
> +
> properties:
> $nodename:
> pattern: "^(flash|.*sram|nand)(@.*)?$"
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml
2024-01-10 11:21 [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml Zhenhua Huang
2024-01-10 19:19 ` Bjorn Andersson
@ 2024-01-16 17:10 ` Rob Herring
2024-02-05 14:50 ` Miquel Raynal
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2024-01-16 17:10 UTC (permalink / raw)
To: Zhenhua Huang
Cc: krzysztof.kozlowski+dt, quic_tingweiz, richard, vigneshr,
conor+dt, linux-kernel, miquel.raynal, linux-mtd, quic_bjorande,
devicetree, robh+dt
On Wed, 10 Jan 2024 19:21:45 +0800, Zhenhua Huang wrote:
> The mtd binding is always $ref'ed by other bindings, default selector
> should be from other binding files which ref'ed it. Now, "$nodename" in
> mtd.yaml turns into a "select" automatically such that a few binding check
> issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> rules in folder sram/*)
>
> To avoid the automatically created "select" in mtd.yaml, adding:
>
> select: false
>
> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> ---
> Hi Bjorn,
>
> As the idea is from your comment, I added "Suggested-by" you.
> Please tell me if that's not suitable. Thanks.
>
> Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml
2024-01-16 17:10 ` Rob Herring
@ 2024-02-05 14:50 ` Miquel Raynal
0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2024-02-05 14:50 UTC (permalink / raw)
To: Rob Herring
Cc: Zhenhua Huang, krzysztof.kozlowski+dt, quic_tingweiz, richard,
vigneshr, conor+dt, linux-kernel, linux-mtd, quic_bjorande,
devicetree, robh+dt
Hi,
robh@kernel.org wrote on Tue, 16 Jan 2024 11:10:05 -0600:
> On Wed, 10 Jan 2024 19:21:45 +0800, Zhenhua Huang wrote:
> > The mtd binding is always $ref'ed by other bindings, default selector
> > should be from other binding files which ref'ed it. Now, "$nodename" in
> > mtd.yaml turns into a "select" automatically such that a few binding check
> > issues reported because it conflicts with sram devices(eg, qcom,imem.yaml,
> > rules in folder sram/*)
> >
> > To avoid the automatically created "select" in mtd.yaml, adding:
> >
> > select: false
> >
> > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> > Fixes: 7bdc671822e9 ("dt-bindings: mtd: physmap: Reuse the generic definitions")
> > Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> > ---
> > Hi Bjorn,
> >
> > As the idea is from your comment, I added "Suggested-by" you.
> > Please tell me if that's not suitable. Thanks.
> >
> > Documentation/devicetree/bindings/mtd/mtd.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to mtd/next, thanks!
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-05 14:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 11:21 [PATCH v2] dt-bindings: mtd: avoid automatically select from mtd.yaml Zhenhua Huang
2024-01-10 19:19 ` Bjorn Andersson
2024-01-16 17:10 ` Rob Herring
2024-02-05 14:50 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox