[PATCH 0/3] mtd: ssfdc: Adjustments for ssfdcr_add_mtd()

[PATCH 0/3] mtd: ssfdc: Adjustments for ssfdcr_add_mtd()

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Dec 2023 15:38:42 +0100

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (3):
  One function call less after error detection
  Fix indentation
  Improve a size determination

 drivers/mtd/ssfdc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--
2.43.0

[PATCH 1/3] mtd: ssfdc: One function call less in ssfdcr_add_mtd() after error detection

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Dec 2023 13:21:52 +0100

The kfree() function was called in one case by
the ssfdcr_add_mtd() function during error handling
even if the passed data structure member contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus use another label.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/mtd/ssfdc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 211f279a33a9..3ee8535d4515 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -332,7 +332,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
 		kmalloc_array(ssfdc->map_len,
 			      sizeof(ssfdc->logic_block_map[0]), GFP_KERNEL);
 	if (!ssfdc->logic_block_map)
-		goto out_err;
+		goto out_free_ssfdc;
 	memset(ssfdc->logic_block_map, 0xff, sizeof(ssfdc->logic_block_map[0]) *
 		ssfdc->map_len);

@@ -350,6 +350,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)

 out_err:
 	kfree(ssfdc->logic_block_map);
+out_free_ssfdc:
         kfree(ssfdc);
 }

--
2.43.0

[PATCH 2/3] mtd: ssfdc: Fix indentation in ssfdcr_add_mtd()

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Dec 2023 15:17:58 +0100

Replace eight space characters by one tab.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/mtd/ssfdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 3ee8535d4515..e6de25087647 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -351,7 +351,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
 out_err:
 	kfree(ssfdc->logic_block_map);
 out_free_ssfdc:
-        kfree(ssfdc);
+	kfree(ssfdc);
 }

 static void ssfdcr_remove_dev(struct mtd_blktrans_dev *dev)
--
2.43.0

Re: [PATCH 0/3] mtd: ssfdc: Adjustments for ssfdcr_add_mtd()

[Miquel Raynal]

Hi Markus,

Markus.Elfring@web.de wrote on Wed, 27 Dec 2023 15:43:06 +0100:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 27 Dec 2023 15:38:42 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (3):
>   One function call less after error detection
>   Fix indentation
>   Improve a size determination
> 
>  drivers/mtd/ssfdc.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> --
> 2.43.0
> 

Series applied on top of mtd/next.

Thanks,
Miquèl