From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A83C45C1C; Mon, 5 Feb 2024 20:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707164363; cv=none; b=pdNU5VXDhjOS9kdVQrIagg0QAgBptnS8BPQyebGkMWd453pAUhoMskC42MVyMLFHOyhDx5wPDuN81RgyJ/QSW3AdDRGfDHqqjZ92OW3lFAk92wuVtm127+IQgT8xP5DRLnY2xf4NdNkk8yz9CdfZwlrM1tU/gpJVXMCtYcbkSnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707164363; c=relaxed/simple; bh=liupdPp9PpabKJrwTtmOwXRlraS5xdM8nIKa3B+TSt8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OdWpgGkjmCWKH3cMSKQD13VUUkwjtsfCtirBbgJpfoZvsUVIGoDf/sm63nQmKdsMEBUT6lwlg9QbJPe84VsXYhcD1psqNDqOoDDOtDnaYHj7n/BdtRRj5idnfp4OoVbOVPiZwZ+y4CCgCL1bag771OoGcA6FZfTEfrSVi4yHSn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q2jTGySi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q2jTGySi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62284C433C7; Mon, 5 Feb 2024 20:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707164362; bh=liupdPp9PpabKJrwTtmOwXRlraS5xdM8nIKa3B+TSt8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q2jTGySiO+5tIbSGAGnj+X1dKVpqXJNRIGBy8IhCrKXvRj/51qGS1fEjrdUDRJHgP wlFuaLb7MAONOYgH8pidL8Sh6FCt+Bw0W5EIfa5RGq8RI5iLl+zQV9DHk0dYIHbH7n pR2UUwJGbmtAOcBd2IrhnA8jb8OQF1sjVu2pw7nxOK0Lau2h0bPRwXZPjhOyb01irH 8xnbO0g3tonhFSyWySir8p6Z+lbqJsRb+soSn+TeUOqQNN6cBG/a/9KmnLaLbdEkQD XXgrDSJfw4IudhIdwiXRE6YzXQHQpDD6fjm+sDe6LUya6OT9WjwERHppLkzi3Y5LGx AhaXjZDXJvsYw== Date: Mon, 5 Feb 2024 12:19:20 -0800 From: Eric Biggers To: Kshitiz Varshney Cc: Herbert Xu , Shawn Guo , Sascha Hauer , Fabio Estevam , dl-linux-imx , Pengutronix Kernel Team , Varun Sethi , Gaurav Jain , Pankaj Gupta , Sahil Malhotra , Vabhav Sharma , Meenakshi Aggarwal , Rahul Kumar Yadav , Nikhil Singla , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test as built in module. Message-ID: <20240205201920.GA2220@sol.localdomain> References: <20240205112933.3084766-1-kshitiz.varshney@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205112933.3084766-1-kshitiz.varshney@nxp.com> On Mon, Feb 05, 2024 at 12:29:33PM +0100, Kshitiz Varshney wrote: > Issue:- > Multiple crypto tests like sm3, sm4 xctr and polyval failing. > > skcipher: failed to allocate transform for xctr(aes): -2 > alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2) > alg: self-tests for sm3 using sm3 failed (rc=-2) > tcrypt: failed to load transform for sm3: -2 > alg: hash: failed to allocate transform for polyval: -2 > alg: self-tests for polyval using polyval failed (rc=-2) > > Resolution:- > Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC, > CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of > sm3, sm4, aria, polyval & xctr. > > Signed-off-by: Kshitiz Varshney This looks like an issue in tcrypt. When algorithms are unavailable it should consider the corresponding test cases to be skipped, not failed. > arch/arm/configs/imx_v6_v7_defconfig | 4 ++++ There should be no need to enable every crypto algorithm in every defconfig file. Can you consider fixing the underlying issue instead of doing that? - Eric