Re: [PATCH v2 1/3] Subject: [PATCH] drm/mediatek/dp: Add tee client application for HDCP feature

CK Hu (胡俊光)
2024-02-20T07:54:07Z

Hi, Mac:

On Mon, 2024-02-05 at 13:50 +0800, mac.shen wrote:
> Add tee client application which will be used for
> HDCP 1.x and 2.x authentication in DisplayPort.
>
> Changes in v2:
> - remove ca folder, and change file name with lower case
> - refine the tci_t structure to make the data to tee can
> through this structure
> - remove aux and regs from mtk_hdcp_info structure
> - remove some definitions, and use the definitions in
> include/drm/drm_hdcp.h
> - remove useless code
> per suggestion from the previous thread:
> https://lore.kernel.org/all/8fff59b5567449d8201dd1138c8fa
> 9218a545c46.camel@mediatek.com/
>
> Signed-off-by: mac.shen <mac.shen@mediatek.com>
> ---

[snip]

> +
> +struct hdcp2_handler {
> + u8 main_state;
> + u8 sub_state;
> + u8 down_stream_dev_cnt;

Useless, drop it.

> + u8 hdcp_rx_ver;

Ditto.

> + bool send_ake_init:1;

You set send_ake_init to ture, but never check it, so it's useless,
drop it.

> + bool get_recv_id_list:1;

Useless, drop it.

> + bool stored_km:1;
> + bool send_lc_init:1;

You set send_lc_init to ture, but never check it, so it's useless, drop
it.

> + bool send_ack:1;

Useless, drop it.

> + bool sink_is_repeater:1;

Ditto.

> + bool recv_msg:1;
> + bool send_pair:1;

You set send_pair to ture, but never check it, so it's useless, drop
it.

Regards,
CK

> + u32 seq_num_v_cnt;
> + u32 retry_cnt;
> +};
> +