* [PATCH] ipack: make ipack_bus_type const
@ 2024-02-04 20:00 Ricardo B. Marliere
2024-02-05 14:41 ` Vaibhav Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 20:00 UTC (permalink / raw)
To: Vaibhav Gupta, Jens Taprogge, Greg Kroah-Hartman
Cc: industrypack-devel, linux-kernel, Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the ipack_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/ipack/ipack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index b1471ba016a5..866bf48d803b 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -187,7 +187,7 @@ static struct attribute *ipack_attrs[] = {
};
ATTRIBUTE_GROUPS(ipack);
-static struct bus_type ipack_bus_type = {
+static const struct bus_type ipack_bus_type = {
.name = "ipack",
.probe = ipack_bus_probe,
.match = ipack_bus_match,
---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-ipack-7e502021db1f
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipack: make ipack_bus_type const
2024-02-04 20:00 [PATCH] ipack: make ipack_bus_type const Ricardo B. Marliere
@ 2024-02-05 14:41 ` Vaibhav Gupta
2024-02-05 19:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Vaibhav Gupta @ 2024-02-05 14:41 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Jens Taprogge, Greg Kroah-Hartman, industrypack-devel,
linux-kernel
On Sun, Feb 04, 2024 at 05:00:13PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the ipack_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
> drivers/ipack/ipack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
> index b1471ba016a5..866bf48d803b 100644
> --- a/drivers/ipack/ipack.c
> +++ b/drivers/ipack/ipack.c
> @@ -187,7 +187,7 @@ static struct attribute *ipack_attrs[] = {
> };
> ATTRIBUTE_GROUPS(ipack);
>
> -static struct bus_type ipack_bus_type = {
> +static const struct bus_type ipack_bus_type = {
> .name = "ipack",
> .probe = ipack_bus_probe,
> .match = ipack_bus_match,
>
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-ipack-7e502021db1f
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
Hello Ricardo,
Thank you for your patch.
Acked-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Greg, would you please add it to your misc tree.
Thanks and regards,
Vaibhav Gupta
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipack: make ipack_bus_type const
2024-02-05 14:41 ` Vaibhav Gupta
@ 2024-02-05 19:07 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 19:07 UTC (permalink / raw)
To: Vaibhav Gupta
Cc: Ricardo B. Marliere, Jens Taprogge, industrypack-devel,
linux-kernel
On Mon, Feb 05, 2024 at 03:41:52PM +0100, Vaibhav Gupta wrote:
> On Sun, Feb 04, 2024 at 05:00:13PM -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the ipack_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> >
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> > ---
> > drivers/ipack/ipack.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
> > index b1471ba016a5..866bf48d803b 100644
> > --- a/drivers/ipack/ipack.c
> > +++ b/drivers/ipack/ipack.c
> > @@ -187,7 +187,7 @@ static struct attribute *ipack_attrs[] = {
> > };
> > ATTRIBUTE_GROUPS(ipack);
> >
> > -static struct bus_type ipack_bus_type = {
> > +static const struct bus_type ipack_bus_type = {
> > .name = "ipack",
> > .probe = ipack_bus_probe,
> > .match = ipack_bus_match,
> >
> > ---
> > base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> > change-id: 20240204-bus_cleanup-ipack-7e502021db1f
> >
> > Best regards,
> > --
> > Ricardo B. Marliere <ricardo@marliere.net>
> >
>
> Hello Ricardo,
>
> Thank you for your patch.
>
> Acked-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
>
> Greg, would you please add it to your misc tree.
Will do, thanks!
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-05 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 20:00 [PATCH] ipack: make ipack_bus_type const Ricardo B. Marliere
2024-02-05 14:41 ` Vaibhav Gupta
2024-02-05 19:07 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox