public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vernet <void@manifault.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	bsegall@google.com, bristot@redhat.com, vschneid@redhat.com,
	kernel-team@meta.com
Subject: [PATCH v3 2/3] sched/fair: Do strict inequality check for busiest misfit task group
Date: Mon,  5 Feb 2024 22:39:20 -0600	[thread overview]
Message-ID: <20240206043921.850302-3-void@manifault.com> (raw)
In-Reply-To: <20240206043921.850302-1-void@manifault.com>

In update_sd_pick_busiest(), when comparing two sched groups that are
both of type group_misfit_task, we currently consider the new group as
busier than the current busiest group even if the new group has the
same misfit task load as the current busiest group. We can avoid some
unnecessary writes if we instead only consider the newest group to be
the busiest if it has a higher load than the current busiest. This
matches the behavior of other group types where we compare load, such as
two groups that are both overloaded.

Let's update the group_misfit_task type comparison to also only update
the busiest group in the event of strict inequality.

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: David Vernet <void@manifault.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e7519ea434b1..76d03106040d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -10028,7 +10028,7 @@ static bool update_sd_pick_busiest(struct lb_env *env,
 		 * If we have more than one misfit sg go with the biggest
 		 * misfit.
 		 */
-		if (sgs->group_misfit_task_load < busiest->group_misfit_task_load)
+		if (sgs->group_misfit_task_load <= busiest->group_misfit_task_load)
 			return false;
 		break;
 
-- 
2.43.0


  parent reply	other threads:[~2024-02-06  4:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  4:39 [PATCH v3 0/3] sched/fair: Simplify and optimize update_sd_pick_busiest() David Vernet
2024-02-06  4:39 ` [PATCH v3 1/3] sched/fair: Remove unnecessary goto in update_sd_lb_stats() David Vernet
2024-02-28 22:00   ` [tip: sched/core] " tip-bot2 for David Vernet
2024-02-06  4:39 ` David Vernet [this message]
2024-02-06 13:17   ` [PATCH v3 2/3] sched/fair: Do strict inequality check for busiest misfit task group Valentin Schneider
2024-02-28 22:00   ` [tip: sched/core] " tip-bot2 for David Vernet
2024-02-06  4:39 ` [PATCH v3 3/3] sched/fair: Simplify some logic in update_sd_pick_busiest() David Vernet
2024-02-28 22:00   ` [tip: sched/core] sched/fair: Simplify the update_sd_pick_busiest() logic tip-bot2 for David Vernet
2024-02-16 19:44 ` [PATCH v3 0/3] sched/fair: Simplify and optimize update_sd_pick_busiest() David Vernet
2024-02-26 17:50   ` David Vernet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206043921.850302-3-void@manifault.com \
    --to=void@manifault.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox