* [PATCH] pci: endpoint: make pci_epf_bus_type const
@ 2024-02-04 20:28 Ricardo B. Marliere
2024-02-05 12:47 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 20:28 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Kishon Vijay Abraham I, Bjorn Helgaas
Cc: linux-pci, linux-kernel, Greg Kroah-Hartman, Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the pci_epf_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/pci/endpoint/pci-epf-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
index 2c32de667937..bf655383e5ed 100644
--- a/drivers/pci/endpoint/pci-epf-core.c
+++ b/drivers/pci/endpoint/pci-epf-core.c
@@ -17,7 +17,7 @@
static DEFINE_MUTEX(pci_epf_mutex);
-static struct bus_type pci_epf_bus_type;
+static const struct bus_type pci_epf_bus_type;
static const struct device_type pci_epf_type;
/**
@@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev)
epf->driver = NULL;
}
-static struct bus_type pci_epf_bus_type = {
+static const struct bus_type pci_epf_bus_type = {
.name = "pci-epf",
.match = pci_epf_device_match,
.probe = pci_epf_device_probe,
---
base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d
change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pci: endpoint: make pci_epf_bus_type const
2024-02-04 20:28 [PATCH] pci: endpoint: make pci_epf_bus_type const Ricardo B. Marliere
@ 2024-02-05 12:47 ` Greg Kroah-Hartman
2024-02-05 14:01 ` Manivannan Sadhasivam
2024-02-06 5:32 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:47 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Kishon Vijay Abraham I, Bjorn Helgaas,
linux-pci, linux-kernel
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the pci_epf_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: endpoint: make pci_epf_bus_type const
2024-02-04 20:28 [PATCH] pci: endpoint: make pci_epf_bus_type const Ricardo B. Marliere
2024-02-05 12:47 ` Greg Kroah-Hartman
@ 2024-02-05 14:01 ` Manivannan Sadhasivam
2024-02-06 5:32 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-05 14:01 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Kishon Vijay Abraham I, Bjorn Helgaas, linux-pci, linux-kernel,
Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the pci_epf_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/pci/endpoint/pci-epf-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
> index 2c32de667937..bf655383e5ed 100644
> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -17,7 +17,7 @@
>
> static DEFINE_MUTEX(pci_epf_mutex);
>
> -static struct bus_type pci_epf_bus_type;
> +static const struct bus_type pci_epf_bus_type;
> static const struct device_type pci_epf_type;
>
> /**
> @@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev)
> epf->driver = NULL;
> }
>
> -static struct bus_type pci_epf_bus_type = {
> +static const struct bus_type pci_epf_bus_type = {
> .name = "pci-epf",
> .match = pci_epf_device_match,
> .probe = pci_epf_device_probe,
>
> ---
> base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d
> change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pci: endpoint: make pci_epf_bus_type const
2024-02-04 20:28 [PATCH] pci: endpoint: make pci_epf_bus_type const Ricardo B. Marliere
2024-02-05 12:47 ` Greg Kroah-Hartman
2024-02-05 14:01 ` Manivannan Sadhasivam
@ 2024-02-06 5:32 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-06 5:32 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Kishon Vijay Abraham I, Bjorn Helgaas, linux-pci, linux-kernel,
Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the pci_epf_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Applied to pci/endpoint!
- Mani
> ---
> drivers/pci/endpoint/pci-epf-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
> index 2c32de667937..bf655383e5ed 100644
> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -17,7 +17,7 @@
>
> static DEFINE_MUTEX(pci_epf_mutex);
>
> -static struct bus_type pci_epf_bus_type;
> +static const struct bus_type pci_epf_bus_type;
> static const struct device_type pci_epf_type;
>
> /**
> @@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev)
> epf->driver = NULL;
> }
>
> -static struct bus_type pci_epf_bus_type = {
> +static const struct bus_type pci_epf_bus_type = {
> .name = "pci-epf",
> .match = pci_epf_device_match,
> .probe = pci_epf_device_probe,
>
> ---
> base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d
> change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-06 5:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 20:28 [PATCH] pci: endpoint: make pci_epf_bus_type const Ricardo B. Marliere
2024-02-05 12:47 ` Greg Kroah-Hartman
2024-02-05 14:01 ` Manivannan Sadhasivam
2024-02-06 5:32 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox