From: Bitao Hu <yaoma@linux.alibaba.com>
To: dianders@chromium.org, akpm@linux-foundation.org,
pmladek@suse.com, kernelfans@gmail.com,
liusong@linux.alibaba.com
Cc: linux-kernel@vger.kernel.org, yaoma@linux.alibaba.com
Subject: [PATCHv5 0/3] *** Detect interrupt storm in softlockup ***
Date: Tue, 6 Feb 2024 17:58:59 +0800 [thread overview]
Message-ID: <20240206095902.56406-1-yaoma@linux.alibaba.com> (raw)
Hi, guys.
I have implemented a low-overhead method for detecting interrupt storm
in softlockup. Please review it, all comments are welcome.
Changes from v4 to v5:
- Rearranging variable placement to make code look neater.
Changes from v3 to v4:
- Renaming some variable and function names to make the code logic
more readable.
- Change the code location to avoid predeclaring.
- Just swap rather than a double loop in tabulate_irq_count.
- Since nr_irqs has the potential to grow at runtime, bounds-check
logic has been implemented.
- Add SOFTLOCKUP_DETECTOR_INTR_STORM Kconfig knob.
Changes from v2 to v3:
- From Liu Song, using enum instead of macro for cpu_stats, shortening
the name 'idx_to_stat' to 'stats', adding 'get_16bit_precesion' instead
of using right shift operations, and using 'struct irq_counts'.
- From kernel robot test, using '__this_cpu_read' and '__this_cpu_write'
instead of accessing to an per-cpu array directly, in order to avoid
this warning.
'sparse: incorrect type in initializer (different modifiers)'
Changes from v1 to v2:
- From Douglas, optimize the memory of cpustats. With the maximum number
of CPUs, that's now this.
2 * 8192 * 4 + 1 * 8192 * 5 * 4 + 1 * 8192 = 237,568 bytes.
- From Liu Song, refactor the code format and add necessary comments.
- From Douglas, use interrupt counts instead of interrupt time to
determine the cause of softlockup.
- Remove the cmdline parameter added in PATCHv1.
Bitao Hu (3):
watchdog/softlockup: low-overhead detection of interrupt
watchdog/softlockup: report the most frequent interrupts
watchdog/softlockup: add SOFTLOCKUP_DETECTOR_INTR_STORM Kconfig knob
kernel/watchdog.c | 245 ++++++++++++++++++++++++++++++++++++++++++++++
lib/Kconfig.debug | 13 +++
2 files changed, 258 insertions(+)
--
2.37.1 (Apple Git-137.1)
next reply other threads:[~2024-02-06 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 9:58 Bitao Hu [this message]
2024-02-06 9:59 ` [PATCHv5 1/3] watchdog/softlockup: low-overhead detection of interrupt Bitao Hu
2024-02-06 21:41 ` Doug Anderson
2024-02-07 6:18 ` Bitao Hu
2024-02-07 17:13 ` Doug Anderson
2024-02-06 9:59 ` [PATCHv5 2/3] watchdog/softlockup: report the most frequent interrupts Bitao Hu
2024-02-06 21:42 ` Doug Anderson
2024-02-07 6:18 ` Bitao Hu
2024-02-07 17:14 ` Doug Anderson
2024-02-06 9:59 ` [PATCHv5 3/3] watchdog/softlockup: add SOFTLOCKUP_DETECTOR_INTR_STORM Kconfig knob Bitao Hu
2024-02-06 21:42 ` Doug Anderson
2024-02-07 6:19 ` Bitao Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206095902.56406-1-yaoma@linux.alibaba.com \
--to=yaoma@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liusong@linux.alibaba.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox