From: Jason Gunthorpe <jgg@ziepe.ca>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@linux.microsoft.com>,
"sharmaajay@microsoft.com" <sharmaajay@microsoft.com>,
Long Li <longli@microsoft.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH rdma-next v2 2/5] RDMA/mana_ib: Create and destroy rnic adapter
Date: Tue, 6 Feb 2024 10:32:20 -0400 [thread overview]
Message-ID: <20240206143220.GF31743@ziepe.ca> (raw)
In-Reply-To: <AS1PR83MB0543AE70836C1DCF1DA42F06B4462@AS1PR83MB0543.EURPRD83.prod.outlook.com>
On Tue, Feb 06, 2024 at 02:20:35PM +0000, Konstantin Taranov wrote:
> > Unless you have a good explanation why you can add new FW command to
> > configure RNIC, but can't add FW command to query if RNIC is supported. I'm
> > not keen on adopting this approach.
>
> The main reason was backward compatibility with old firmware that had the
> aforementioned limitation. Anyway, we will try to internally retire the old firmware
> and will send the v3 patches without the "try and fail" approach (in 2-3 weeks).
I think this is the right thing to do for these cloud devices that can
reliably retire old software. It is how Amazon has been running
EFA. Get your deployment in good shape and then get patches comitted
upstream. No reason to suffer with backwards compatability forever in
the software to save a few weeks.
Jason
next prev parent reply other threads:[~2024-02-06 14:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 15:06 [PATCH rdma-next v2 0/5] RDMA/mana_ib: Enable RNIC adapter and populate it with GIDs Konstantin Taranov
2024-02-02 15:06 ` [PATCH rdma-next v2 1/5] RDMA/mana_ib: Add EQ creation for rnic adapter Konstantin Taranov
2024-02-04 12:25 ` Leon Romanovsky
2024-02-02 15:06 ` [PATCH rdma-next v2 2/5] RDMA/mana_ib: Create and destroy " Konstantin Taranov
2024-02-04 12:30 ` Leon Romanovsky
2024-02-04 15:50 ` [EXTERNAL] " Konstantin Taranov
2024-02-04 16:51 ` Leon Romanovsky
2024-02-04 17:17 ` Konstantin Taranov
2024-02-05 7:54 ` Leon Romanovsky
2024-02-05 9:15 ` Konstantin Taranov
2024-02-05 9:57 ` Leon Romanovsky
2024-02-06 14:20 ` Konstantin Taranov
2024-02-06 14:32 ` Jason Gunthorpe [this message]
2024-02-02 15:06 ` [PATCH rdma-next v2 3/5] RDMA/mana_ib: Implement port parameters Konstantin Taranov
2024-02-02 15:06 ` [PATCH rdma-next v2 4/5] RDMA/mana_ib: Enable RoCE on port 1 Konstantin Taranov
2024-02-02 15:06 ` [PATCH rdma-next v2 5/5] RDMA/mana_ib: Adding and deleting GIDs Konstantin Taranov
2024-02-04 12:43 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206143220.GF31743@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox