From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+3b1d4b3d5f7a358bf9a9@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [usb?] [media?] possible deadlock in vb2_video_unregister_device
Date: Wed, 7 Feb 2024 19:07:56 +0800 [thread overview]
Message-ID: <20240207110756.936-1-hdanton@sina.com> (raw)
In-Reply-To: <0000000000008b96230610c6b3fe@google.com>
On Wed, 07 Feb 2024 00:44:22 -0800
> HEAD commit: ed5551279c91 Merge 6.8-rc3 into usb-next
> git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1603629fe80000
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
--- x/drivers/media/usb/usbtv/usbtv-video.c
+++ y/drivers/media/usb/usbtv/usbtv-video.c
@@ -963,11 +963,11 @@ ctrl_fail:
void usbtv_video_free(struct usbtv *usbtv)
{
+ usbtv_stop(usbtv);
+ vb2_video_unregister_device(&usbtv->vdev);
mutex_lock(&usbtv->vb2q_lock);
mutex_lock(&usbtv->v4l2_lock);
- usbtv_stop(usbtv);
- vb2_video_unregister_device(&usbtv->vdev);
v4l2_device_disconnect(&usbtv->v4l2_dev);
mutex_unlock(&usbtv->v4l2_lock);
--
next prev parent reply other threads:[~2024-02-07 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 8:44 [syzbot] [usb?] [media?] possible deadlock in vb2_video_unregister_device syzbot
2024-02-07 11:07 ` Hillf Danton [this message]
2024-02-07 11:24 ` syzbot
2024-02-16 5:45 ` Tomasz Figa
2024-02-19 13:10 ` syzbot
2024-02-19 15:49 ` Benjamin Gaignard
2024-02-20 4:49 ` Tomasz Figa
2024-06-08 23:51 ` [syzbot] [media?] [usb?] " syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207110756.936-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+3b1d4b3d5f7a358bf9a9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox