public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Kunwu Chan <chentao@kylinos.cn>, Vinod Koul <vkoul@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	peter.ujfalusi@gmail.com, dmaengine@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 05/29] dmaengine: ti: edma: Add some null pointer checks to the edma_probe
Date: Wed,  7 Feb 2024 16:24:30 -0500	[thread overview]
Message-ID: <20240207212505.3169-5-sashal@kernel.org> (raw)
In-Reply-To: <20240207212505.3169-1-sashal@kernel.org>

From: Kunwu Chan <chentao@kylinos.cn>

[ Upstream commit 6e2276203ac9ff10fc76917ec9813c660f627369 ]

devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Link: https://lore.kernel.org/r/20240118031929.192192-1-chentao@kylinos.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/dma/ti/edma.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index 7ec6e5d728b0..9212ac9f978f 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -2413,6 +2413,11 @@ static int edma_probe(struct platform_device *pdev)
 	if (irq > 0) {
 		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint",
 					  dev_name(dev));
+		if (!irq_name) {
+			ret = -ENOMEM;
+			goto err_disable_pm;
+		}
+
 		ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
 				       ecc);
 		if (ret) {
@@ -2429,6 +2434,11 @@ static int edma_probe(struct platform_device *pdev)
 	if (irq > 0) {
 		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint",
 					  dev_name(dev));
+		if (!irq_name) {
+			ret = -ENOMEM;
+			goto err_disable_pm;
+		}
+
 		ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,
 				       ecc);
 		if (ret) {
-- 
2.43.0


  parent reply	other threads:[~2024-02-07 21:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 21:24 [PATCH AUTOSEL 6.1 01/29] ext4: avoid dividing by 0 in mb_update_avg_fragment_size() when block bitmap corrupt Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 02/29] ext4: avoid allocating blocks from corrupted group in ext4_mb_try_best_found() Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 03/29] ext4: avoid allocating blocks from corrupted group in ext4_mb_find_by_goal() Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 04/29] Input: goodix - accept ACPI resources with gpio_count == 3 && gpio_int_idx == 0 Sasha Levin
2024-02-07 21:24 ` Sasha Levin [this message]
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 06/29] ASoC: codecs: wcd934x: drop unneeded regulator include Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 07/29] regulator: pwm-regulator: Add validity checks in continuous .get_voltage Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 08/29] nvmet-tcp: fix nvme tcp ida memory leak Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 09/29] usb: ucsi_acpi: Quirk to ack a connector change ack cmd Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 10/29] ALSA: usb-audio: Check presence of valid altsetting control Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 11/29] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 12/29] spi: sh-msiof: avoid integer overflow in constants Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 13/29] Input: xpad - add Lenovo Legion Go controllers Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 14/29] misc: open-dice: Fix spurious lockdep warning Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 15/29] netfilter: conntrack: check SCTP_CID_SHUTDOWN_ACK for vtag setting in sctp_new Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 16/29] drm/amd/display: increased min_dcfclk_mhz and min_fclk_mhz Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 17/29] ASoC: wm_adsp: Don't overwrite fwf_name with the default Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 18/29] ALSA: usb-audio: Ignore clock selector errors for single connection Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 19/29] nvme-fc: do not wait in vain when unloading module Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 20/29] nvmet-fcloop: swap the list_add_tail arguments Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 21/29] nvmet-fc: release reference on target port Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 22/29] nvmet-fc: defer cleanup using RCU properly Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 23/29] nvmet-fc: hold reference on hostport match Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 24/29] nvmet-fc: abort command when there is no binding Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 25/29] nvmet-fc: avoid deadlock on delete association path Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 26/29] nvmet-fc: take ref count on tgtport before delete assoc Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 27/29] smb: client: increase number of PDUs allowed in a compound request Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 28/29] ext4: correct the hole length returned by ext4_map_blocks() Sasha Levin
2024-02-07 21:24 ` [PATCH AUTOSEL 6.1 29/29] Input: i8042 - add Fujitsu Lifebook U728 to i8042 quirk table Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207212505.3169-5-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chentao@kylinos.cn \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox