From: Greg KH <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: set device type for GPIO chips
Date: Wed, 7 Feb 2024 13:49:34 +0000 [thread overview]
Message-ID: <2024020723-arbitrary-harmful-53c3@gregkh> (raw)
In-Reply-To: <CAMRc=MeWD-4xx9Y=P3ajO37XJAsBrZ2TyqNeCE8vkxXW1yXWVQ@mail.gmail.com>
On Wed, Feb 07, 2024 at 01:19:37PM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 7, 2024 at 11:49 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Feb 07, 2024 at 11:45:39AM +0100, Linus Walleij wrote:
> > > On Thu, Feb 1, 2024 at 5:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > It's useful to have the device type information for those sub-devices
> > > > that are actually GPIO chips registered with GPIOLIB. While at it: use
> > > > the device type struct to setup the release callback which is the
> > > > preferred way to use the device API.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > (...=
> > > > +static struct device_type gpio_dev_type = {
> >
> > Can you make this structure const please?
> >
>
> I have, there's a v2 on the list already.
Great, let me go dig that up and do a review...
prev parent reply other threads:[~2024-02-07 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 16:27 [PATCH] gpio: set device type for GPIO chips Bartosz Golaszewski
2024-02-07 10:45 ` Linus Walleij
2024-02-07 10:49 ` Greg KH
2024-02-07 12:19 ` Bartosz Golaszewski
2024-02-07 13:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024020723-arbitrary-harmful-53c3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox