From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Ye Bin <yebin10@huawei.com>
Cc: <rostedt@goodmis.org>, <mathieu.desnoyers@efficios.com>,
<linux-trace-kernel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/8] tracing: add new type "%pd/%pD" in readme_msg[]
Date: Wed, 7 Feb 2024 23:32:56 +0900 [thread overview]
Message-ID: <20240207233256.10fe8dbc8451d5be8bb6ecd1@kernel.org> (raw)
In-Reply-To: <20240125073923.2252057-6-yebin10@huawei.com>
On Thu, 25 Jan 2024 15:39:20 +0800
Ye Bin <yebin10@huawei.com> wrote:
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> kernel/trace/trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2a7c6fd934e9..13197d3b86bd 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -5745,7 +5745,7 @@ static const char readme_msg[] =
> "\t +|-[u]<offset>(<fetcharg>), \\imm-value, \\\"imm-string\"\n"
> "\t type: s8/16/32/64, u8/16/32/64, x8/16/32/64, char, string, symbol,\n"
> "\t b<bit-width>@<bit-offset>/<container-size>, ustring,\n"
> - "\t symstr, <type>\\[<array-size>\\]\n"
> + "\t symstr, %pd/%pD <type>\\[<array-size>\\]\n"
Almost! you missed the ',' after %pd/%pD. :)
Thank you,
> #ifdef CONFIG_HIST_TRIGGERS
> "\t field: <stype> <name>;\n"
> "\t stype: u8/u16/u32/u64, s8/s16/s32/s64, pid_t,\n"
> --
> 2.31.1
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-02-07 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 7:39 [PATCH v5 0/8] support '%pd' and '%pD' for print file name Ye Bin
2024-01-25 7:39 ` [PATCH v5 1/8] tracing/probes: add traceprobe_expand_dentry_args() helper Ye Bin
2024-02-07 14:29 ` Masami Hiramatsu
2024-01-25 7:39 ` [PATCH v5 2/8] tracing/probes: support '%pd' type for print struct dentry's name Ye Bin
2024-01-25 7:39 ` [PATCH v5 3/8] tracing/probes: support '%pD' type for print struct file's name Ye Bin
2024-01-25 7:39 ` [PATCH v5 4/8] tracing/probes: support '%pd/%pD' type for fprobe Ye Bin
2024-02-07 14:31 ` Masami Hiramatsu
2024-01-25 7:39 ` [PATCH v5 5/8] tracing: add new type "%pd/%pD" in readme_msg[] Ye Bin
2024-02-07 14:32 ` Masami Hiramatsu [this message]
2024-01-25 7:39 ` [PATCH v5 6/8] Documentation: tracing: add new type '%pd' and '%pD' for kprobe Ye Bin
2024-01-25 7:39 ` [PATCH v5 7/8] selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD" Ye Bin
2024-02-07 14:39 ` Masami Hiramatsu
2024-01-25 7:39 ` [PATCH v5 8/8] selftests/ftrace: add fprobe " Ye Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207233256.10fe8dbc8451d5be8bb6ecd1@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox