From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joy Chakraborty <joychakr@google.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
linux-kernel@vger.kernel.org, manugautam@google.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: rmem: Fix return value of rmem_read()
Date: Wed, 7 Feb 2024 09:34:02 +0000 [thread overview]
Message-ID: <2024020734-curliness-licking-44c1@gregkh> (raw)
In-Reply-To: <CAOSNQF2_qy51Z01DKO1MB-d+K4EaXGDkof1T4pHNO10U_Hm0WQ@mail.gmail.com>
On Tue, Feb 06, 2024 at 05:22:15PM +0530, Joy Chakraborty wrote:
> > > Userspace will see a false error with nvmem cell reads from
> > > nvmem_cell_attr_read() in current code, which should be fixed on
> > > returning 0 for success.
> >
> > So maybe fix this all up to allow the read to return the actual amount
> > read? That feels more "correct" to me.
> >
>
> If I change the behavior of the nvmem_reg_read_t callback to negative
> for error and number of bytes actually read for success then, other
> than the core driver I would also have to change all the
> nvmem-provider drivers.
> Is it okay to do so ?
Sure, why not? That seems like the correct fix to me, right?
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-07 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 4:24 [PATCH v2] nvmem: rmem: Fix return value of rmem_read() Joy Chakraborty
2024-02-06 9:30 ` Greg Kroah-Hartman
2024-02-06 10:31 ` Joy Chakraborty
2024-02-06 10:56 ` Greg Kroah-Hartman
2024-02-06 11:52 ` Joy Chakraborty
2024-02-07 9:34 ` Greg Kroah-Hartman [this message]
2024-02-07 15:03 ` Joy Chakraborty
2024-02-27 6:57 ` Joy Chakraborty
2024-02-27 7:32 ` Greg Kroah-Hartman
2024-02-27 8:31 ` Joy Chakraborty
2024-02-06 22:36 ` Srinivas Kandagatla
2024-02-07 6:35 ` Joy Chakraborty
2024-02-07 9:30 ` Srinivas Kandagatla
2024-02-07 14:46 ` Joy Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024020734-curliness-licking-44c1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=joychakr@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manugautam@google.com \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox